Skip to content

chore(ci): enable noctx linter #4972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julio-lopez merged 4 commits into from
Nov 20, 2025
Merged

chore(ci): enable noctx linter #4972

julio-lopez merged 4 commits into from
Nov 20, 2025

Conversation

@NathanBaulch
Copy link
Contributor

@NathanBaulch NathanBaulch commented Nov 11, 2025

As requested in #4931.

@julio-lopez julio-lopez mentioned this pull request Nov 12, 2025
Merged
@codecov
Copy link

codecov bot commented Nov 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.04%. Comparing base (cb455c6) to head (10e6ef7).
⚠️ Report is 777 commits behind head on master.

Files with missing lines Patch % Lines
internal/mount/mount_posix_webdav_helper_linux.go 0.00% 3 Missing ⚠️
internal/mount/mount_posix_webdav_helper.go 0.00% 1 Missing ⚠️
internal/mount/mount_webdav.go 0.00% 1 Missing ⚠️
repo/blob/sftp/sftp_storage.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4972      +/-   ##
==========================================
+ Coverage   75.86%   78.04%   +2.17%     
==========================================
  Files         470      548      +78     
  Lines       37301    31398    -5903     
==========================================
- Hits        28299    24503    -3796     
+ Misses       7071     4849    -2222     
- Partials     1931     2046     +115

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

julio-lopez added a commit to julio-lopez/kopia that referenced this pull request Nov 19, 2025
@julio-lopez
chore(general): use contexts in tests
b85ec40 
Ref:
- Subset of the changes proposed by @NathanBaulch in kopia#4972
@julio-lopez julio-lopez mentioned this pull request Nov 19, 2025
Merged
julio-lopez added a commit that referenced this pull request Nov 19, 2025
@julio-lopez
chore(general): use contexts in tests (#5009)
7586b21 
Ref:
- Subset of the changes proposed by @NathanBaulch in #4972
julio-lopez added a commit to julio-lopez/kopia that referenced this pull request Nov 19, 2025
@julio-lopez
chore(ci): pass context in helpers for running docker
8bd7fd4 
- Ref: kopia#4972
@julio-lopez julio-lopez mentioned this pull request Nov 19, 2025
Merged
julio-lopez added a commit to julio-lopez/kopia that referenced this pull request Nov 19, 2025
@julio-lopez
chore(ci): pass context in helpers for running docker
5102fcc 
- Ref: kopia#4972
julio-lopez added a commit that referenced this pull request Nov 19, 2025
@julio-lopez
chore(ci): pass context in helpers for running docker (#5012)
7b64425 
- Ref: #4972
@NathanBaulch
Copy link
Contributor Author

NathanBaulch commented Nov 19, 2025

Ha, I've never had my PR branch completely rewritten (rebased) before! All good, whatever it takes to get it in...

@julio-lopez
Copy link
Collaborator

julio-lopez commented Nov 19, 2025

Apologies, there were rebase conflicts.
You can disallow edits to the branch from maintainers.

@julio-lopez julio-lopez merged commit ea1bdb1 into kopia:master Nov 20, 2025
26 of 27 checks passed
@julio-lopez
Copy link
Collaborator

julio-lopez commented Nov 20, 2025

Thanks!

@NathanBaulch NathanBaulch deleted the noctx branch November 20, 2025 05:48
@julio-lopez julio-lopez mentioned this pull request Nov 26, 2025
Merged
julio-lopez added a commit that referenced this pull request Nov 26, 2025
@julio-lopez
fix(providers): execute rclone with non-cancelling context (#5040)
e456f78 
- test rclone after canceling starting context
- execute rclone with non-cancelling context
- create initial SFTP connection with non-canceling context
- nit: use context.WithoutCancel instead of Background
- Fixes #5039
- Ref #4972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julio-lopez julio-lopez julio-lopez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NathanBaulch @julio-lopez