chore(ci): use contexts in tests #5009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: - Subset of the changes proposed by @NathanBaulch in kopia#4972
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5009 +/- ##
==========================================
+ Coverage 75.86% 78.02% +2.16%
==========================================
Files 470 548 +78
Lines 37301 31398 -5903
==========================================
- Hits 28299 24499 -3800
+ Misses 7071 4850 -2221
- Partials 1931 2049 +118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates multiple test files to use context-aware command execution, replacing exec.Command with exec.CommandContext and net.Listen/net.Dial with their context-aware equivalents. This change aligns with Go best practices for cancellable operations and proper resource cleanup in tests.
Key changes:
- Introduces
testlogging.Context(t)to create test contexts - Replaces
exec.Commandwithexec.CommandContextacross test files - Updates network operations to use context-aware methods
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/tools/fio/fio.go | Uses context.Background() for FIO command execution |
| tests/testenv/cli_exe_runner.go | Uses existing ctx parameter for CLI command execution |
| tests/socketactivation_test/socketactivation_test.go | Creates test context and uses it for network listeners |
| tests/recovery/recovery_test/recovery_test.go | Creates test context and uses it for multiple command executions |
| repo/blob/sftp/sftp_storage_test.go | Creates test context for command execution and network dialing |
| repo/blob/rclone/rclone_storage_test.go | Creates test context for rclone command executions |
| internal/editor/editor.go | Uses existing ctx parameter for editor command execution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: