refactor(general): modernize #4903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes Go code by adopting newer standard library APIs introduced in recent Go versions. The changes follow recommendations from the golang.org/x/tools/gopls/internal/analysis/modernize tool.
Key changes:
- Replaced
strings.Split()iteration patterns withstrings.SplitSeq()for more efficient sequential processing - Replaced manual map copying loops with
maps.Copy()for clearer intent and better performance - Replaced
strings.HasPrefix() + strings.TrimPrefix()patterns withstrings.CutPrefix()for atomic prefix handling - Replaced
sort.Slice()calls withslices.Sort()for simpler, more idiomatic sorting
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/gettool/gettool.go | Replaced strings.Split iteration with strings.SplitSeq |
| tests/tools/kopiarunner/kopia_snapshotter.go | Replaced multiple strings.Split iterations with strings.SplitSeq and strings.FieldsSeq |
| tests/tools/fio/options.go | Replaced manual map copy loops with maps.Copy |
| tests/robustness/fiofilewriter/fio_filewriter.go | Replaced manual map copy loops with maps.Copy |
| tests/end_to_end_test/snapshot_fail_test.go | Replaced manual map copy loops with maps.Copy |
| tests/end_to_end_test/repository_connect_test.go | Replaced strings.HasPrefix + TrimPrefix with strings.CutPrefix |
| tests/end_to_end_test/auto_update_test.go | Replaced manual map copy loop with maps.Copy |
| snapshot/manager.go | Replaced manual map copy loop with maps.Copy |
| repo/manifest/manifest_manager_test.go | Replaced sort.Slice with slices.Sort |
| repo/compression/compressor_test.go | Replaced sort.Slice with slices.Sort |
| repo/blob/webdav/webdav_storage_test.go | Replaced manual map copy loop with maps.Copy |
| notification/sender/webhook/webhook_sender.go | Replaced strings.Split iteration with strings.SplitSeq |
| internal/uitask/uitask_counter.go | Replaced manual map copy loop with maps.Copy |
| internal/testutil/tmpdir.go | Replaced strings.Split iteration with strings.SplitSeq |
| internal/testutil/serverparameters.go | Replaced multiple strings.HasPrefix + TrimPrefix patterns with strings.CutPrefix |
| internal/server/server_mount_manager.go | Replaced manual map copy loop with maps.Copy |
| internal/server/server.go | Replaced manual map copy loops with maps.Copy |
| internal/releasable/releaseable_tracker.go | Replaced manual map copy loop with maps.Copy |
| internal/cache/content_cache_test.go | Replaced sort.Slice with slices.Sort, removed unused sort import |
| internal/blobtesting/object_locking_map.go | Replaced sort.Slice with slices.Sort |
| internal/blobtesting/map.go | Replaced sort.Slice with slices.Sort |
| internal/blobtesting/asserts.go | Replaced sort.Slice with slices.Sort |
| fs/cachefs/cache_test.go | Replaced manual map copy loop with maps.Copy |
| cli/command_server_tls.go | Replaced strings.HasPrefix + TrimPrefix with strings.CutPrefix |
| cli/command_policy_set_scheduling.go | Replaced strings.Split iterations with strings.SplitSeq |
| cli/command_blob_shards_modify.go | Replaced strings.Split iteration with strings.SplitSeq |
| cli/command_benchmark_compression.go | Replaced strings.Split iteration with strings.SplitSeq |
| cli/command_acl_add.go | Replaced strings.Split iteration with strings.SplitSeq |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| fields := strings.FieldsSeq(l) | ||
|
|
||
| for _, f := range fields { | ||
| for f := range fields { |
There was a problem hiding this comment.
This code attempts to range over the result of strings.FieldsSeq, which does not exist. Even if it did exist and returned an iterator, the iteration would need to be updated to match the iterator protocol. Since strings.Fields returns []string, this should be for _, f := range fields.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4903 +/- ##
==========================================
+ Coverage 75.86% 77.96% +2.09%
==========================================
Files 470 537 +67
Lines 37301 31216 -6085
==========================================
- Hits 28299 24336 -3963
+ Misses 7071 4837 -2234
- Partials 1931 2043 +112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the modernize changes for the following categories:
Refs: