chore(general): modernize min/max #4898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the codebase by replacing manual min/max conditional logic with Go's built-in min() and max() functions (available since Go 1.21). The changes improve code readability and reduce verbosity while maintaining identical functionality.
Key changes:
- Replaced manual min/max patterns (if-else comparisons) with built-in
min()andmax()functions - Applied changes consistently across multiple packages including splitter, format, blob, and internal utilities
- Preserved existing logic and behavior while simplifying code structure
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| repo/splitter/splitter_rabinkarp64.go | Replaced manual min/max logic with built-in functions in split point calculation |
| repo/splitter/splitter_buzhash32.go | Replaced manual min/max logic with built-in functions in split point calculation |
| repo/format/format_blob.go | Simplified chunk length calculation using min() |
| repo/blob/s3/s3_versioned_test.go | Replaced manual min logic in test helper with min() |
| internal/uitask/uitask_manager.go | Simplified sleep interval calculation using min() |
| internal/timetrack/estimator.go | Replaced manual max logic with max() for time duration |
| internal/sleepable/sleepable_timer.go | Simplified sleep time calculation using min() |
| internal/retry/retry.go | Simplified exponential backoff calculation using min() |
| internal/gather/gather_write_buffer.go | Replaced manual min logic in buffer append with min() |
| internal/gather/gather_bytes.go | Simplified size calculation using min() |
| internal/epoch/epoch_manager.go | Simplified exponential backoff delay calculation using min() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4898 +/- ##
==========================================
+ Coverage 75.86% 76.74% +0.88%
==========================================
Files 470 537 +67
Lines 37301 40932 +3631
==========================================
+ Hits 28299 31414 +3115
- Misses 7071 7478 +407
- Partials 1931 2040 +109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bb0ea86 to
0ddc332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.