test(general): fix endurance test failures #4859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4859 +/- ##
==========================================
+ Coverage 75.86% 76.82% +0.95%
==========================================
Files 470 535 +65
Lines 37301 40932 +3631
==========================================
+ Hits 28299 31444 +3145
- Misses 7071 7445 +374
- Partials 1931 2043 +112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prevent running "auto-maintenance" on snapshot create. Ref: - kopia#4851
e924221 to
ea29d59
Compare
Collaborator
Author
There was a problem hiding this comment.
Pull Request Overview
This PR fixes endurance test failures by preventing auto-maintenance from running during snapshot creation operations. The issue was caused by concurrent endurance test runners advancing the clock significantly, which triggered clock skewness failures when auto-maintenance ran during snapshot operations.
- Added
--no-auto-maintenanceflag to snapshot create commands in endurance tests - Prevents concurrent clock advancement conflicts between test runners and auto-maintenance
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent running "auto-maintenance" on snapshot create.
Ref:
Context: the test fails because there are concurrent "endurance" runners and each of these advances the clock, some of them significantly (
action{Small,Medium,Large}ClockJump), which causes the clock skewness check to fail when (auto-)maintenance runs. The test maintenance action does not run into this issue because it runs exclusively on its own, that is, other actions have to wait until maintenance completes.