Skip to content

chore(ci): bump golangci-lint to v2.1.2 #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julio-lopez merged 2 commits into from
Apr 16, 2025
Merged

chore(ci): bump golangci-lint to v2.1.2 #4500

julio-lopez merged 2 commits into from
Apr 16, 2025

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 13, 2025

No description provided.

@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 11 times, most recently from e410e0e to 064a451 Compare April 14, 2025 16:47
@jkowalski jkowalski changed the title chore: bump golangci-lint to v2.1.1 chore(ci): bump golangci-lint to v2.1.1 Apr 14, 2025
@jkowalski
Copy link
Contributor

jkowalski commented Apr 14, 2025

thanks for doing this!

jkowalski
jkowalski reviewed Apr 14, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.31%. Comparing base (cb455c6) to head (434b69d).
Report is 469 commits behind head on master.

Files with missing lines Patch % Lines
internal/server/grpc_session.go 75.00% 0 Missing and 1 partial ⚠️
repo/ecc/ecc_rs_crc.go 0.00% 0 Missing and 1 partial ⚠️
repo/format/format_manager.go 0.00% 0 Missing and 1 partial ⚠️
repo/initialize.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4500      +/-   ##
==========================================
+ Coverage   75.86%   76.31%   +0.44%     
==========================================
  Files         470      528      +58     
  Lines       37301    40050    +2749     
==========================================
+ Hits        28299    30563    +2264     
- Misses       7071     7469     +398     
- Partials     1931     2018      +87

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mmorel-35
mmorel-35 commented Apr 14, 2025
View reviewed changes
@mmorel-35 mmorel-35 marked this pull request as ready for review April 14, 2025 17:35
julio-lopez
julio-lopez requested changes Apr 15, 2025
View reviewed changes
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 2 times, most recently from d99e82e to 9517108 Compare April 15, 2025 04:59
@mmorel-35 mmorel-35 changed the title chore(ci): bump golangci-lint to v2.1.1 chore(ci): bump golangci-lint to v2.1.2 Apr 16, 2025
@mmorel-35
chore: bump golangci-lint to v2.1.2
57c05e9 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@julio-lopez
Copy link
Collaborator

julio-lopez commented Apr 16, 2025

@mmorel-35 To facilitate and speed up the review process, please push separate commits with the new changes when this PR, instead of squashing everything into a single commit.
All the commits will be squashed at the end before merging the PR.

@mmorel-35
fix wsl issue
434b69d 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
julio-lopez
julio-lopez approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@julio-lopez julio-lopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇Thanks for doing this.

@julio-lopez julio-lopez merged commit 675e958 into kopia:master Apr 16, 2025
23 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint@v2 branch April 16, 2025 05:52
julio-lopez added a commit to julio-lopez/kopia that referenced this pull request Apr 17, 2025
@julio-lopez
chore(ci): enable exptostd linter
07e16cb 
- Ref: kopia#4500
@julio-lopez julio-lopez mentioned this pull request Apr 17, 2025
Merged
julio-lopez added a commit to julio-lopez/kopia that referenced this pull request Apr 17, 2025
@julio-lopez
chore(ci): enable exptostd linter
3bba070 
- Add exclusion for x/exp/constraints
- Ref: kopia#4500
julio-lopez added a commit to julio-lopez/kopia that referenced this pull request Apr 17, 2025
@julio-lopez
chore(ci): enable exptostd linter
190c536 
- Cleanup `x/exp/constraints` usage
- Ref: kopia#4500
julio-lopez added a commit that referenced this pull request Apr 17, 2025
@julio-lopez
chore(ci): enable exptostd linter (#4509)
3712fc4 
Also, cleanup `x/exp/constraints` usage to address linter warning.

Ref:
- #4500
- #4507 (contains prior migration from `x/exp` to stdlib packages)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julio-lopez julio-lopez julio-lopez approved these changes

@jkowalski jkowalski Awaiting requested review from jkowalski

+1 more reviewer

@ldez ldez ldez left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mmorel-35 @jkowalski @julio-lopez @ldez