feat(providers): GCS immutability #4134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2024
julio-lopez
approved these changes
Sep 27, 2024
Collaborator
julio-lopez
left a comment
There was a problem hiding this comment.
@KastenMike
🥇 Thanks for doing this.
👍 Looks good: ➕1
This was referenced Sep 27, 2024
|
thank you so much for this |
|
i think docs should be fixed, the first part say that GCS doesn't support the needed features but thats not true anymore (they are still not supported if using the S3 compatibility mode, but the native GCS supports everything we need)
|
Contributor
Author
Ah I missed that part of the docs when I did a docs tweak. But #4151 needs merging for it to fully work |
alvistar
pushed a commit
to alvistar/kopia
that referenced
this pull request
Oct 29, 2024
- Allow blob `Put/ExtendBlobRetention` - PITR support - PITR/versioning tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems not possible to create a PR train in this repo. I created 1 PR but the base only shows me master or providers. So instead it's broken down by commits.
Put/Extend commit: Adds
ExtendBlobRetentionand removes theErrUnsupportedPutBlobOptioncheck fromPutBlob. Also some slight refactorings to make it more likeazure_storage.goand tweak to support getting a blob by its versionID.PITR commit: Code is largely identical to
azure_ands3_equivalents. Based on @kreare's #3564 but more complete.Tests commit:
gcs_immu_test.goandgcs_versioned_test.goare basically identical toazure_equivalents. OnlycreateBucketis a bit different based on Google client. Tweakedgcs_storage_test.goslightly to make it more like the az/s3 ones with consts for env varsRequires variables setting to create/use the new bucket
Ref: