[Kotlin] Ability to generate sealed interfaces#869
Merged
Conversation
Contributor
Author
|
Sonar is failing for mysterious reasons |
kbrooks
commented
Nov 17, 2021
kbrooks
commented
Nov 17, 2021
Contributor
Author
|
java interface is missing "permits" |
added 2 commits
November 17, 2021 15:28
aldib
added a commit
to aldib/graphql-java-codegen
that referenced
this pull request
Dec 7, 2021
Co-authored-by: Kyle <kbrooks@github.com>
aldib
added a commit
to aldib/graphql-java-codegen
that referenced
this pull request
Dec 7, 2021
Co-authored-by: Kyle <kbrooks@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
sealedkeyword to generated interfaces and unions in order to enable exhaustive type-checking in written code. Only works in and in Kotlin, even though Scala has support for sealed interfaces, because Scala has the restriction that classes inheriting a sealed interface are in the same file as that interface. Java has support for sealed interfaces but requires apermits A, B, ...syntax that makes it more difficult to support since we would need to parse the entire schema for all values that implement a given interface.Related to #868
Changes were made to: