Save kotlin nullable sign for custom type mapping and apiReturnType#1020
Merged
Conversation
Tests that used System.lineSeparator() in expectations was failing on Windows because in reality we always generate files with unix line separator
Contributor
Author
|
Fixed codestyle errors. Sorry for not doing it before creating PR, I just coudn't start checkstyle locally. It would be nice to specify checkstyle version 8.41 in CONTRIBUTING.md (I tried 10.4 that is default in IDEA, 9.3 and 8.3 - every version throw exception when select |
kobylynskyi
approved these changes
Feb 26, 2023
Owner
|
@romash1408 thanks for working on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #1019
Also tests were updated to pass on Windows
Changes were made to: