update labelsNode to match new labels interface in kube 1.34#1584
Merged
imjasonh merged 1 commit intoko-build:mainfrom Dec 9, 2025
Merged
update labelsNode to match new labels interface in kube 1.34#1584imjasonh merged 1 commit intoko-build:mainfrom
imjasonh merged 1 commit intoko-build:mainfrom
Conversation
f30ba4a to
2d76d68
Compare
3 tasks
imjasonh
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening after the auto-close of #1545
This change will need to be applied in order for ko to work with kube 1.34+ dependencies. This change is small, completely backwards-compatible, and increases the coverage of the original implementation by adding tests for
labelsNode.