update labelsNode to match new labels interface in kube 1.34#1545
Closed
ecordell wants to merge 1 commit intoko-build:mainfrom
Closed
update labelsNode to match new labels interface in kube 1.34#1545ecordell wants to merge 1 commit intoko-build:mainfrom
ecordell wants to merge 1 commit intoko-build:mainfrom
Conversation
70256f5 to
f30ba4a
Compare
|
This Pull Request is stale because it has been open for 90 days with |
Contributor
Author
|
Hey I'd love to re-open and get this going? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this when pulling ko in as a library:
I updated the
labelsNodeimplementation to match the new interface. I didn't update the apimachinery dependency in this PR; I'm assuming that ko prefers to track released versions only. This should mean that when it's time to update, there are no conflicts.