Skip to content

Conversation

@knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #13829

Queue-proxy sidecar will now perform a graceful shutdown

krsna-m and others added 2 commits March 31, 2023 13:45
- single handlers are now assosciated with multiple servers
- main server is now shutdown
- metrics should work whether we receive requests on TLS or HTTP
@knative-prow knative-prow bot added the area/API API objects and controllers label Mar 31, 2023
@knative-prow knative-prow bot requested review from carlisia, julz and vagababov March 31, 2023 13:45
@knative-prow knative-prow bot added area/autoscale area/networking size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2023
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2023
@knative-prow knative-prow bot merged commit fc9c130 into knative:release-1.8 Mar 31, 2023
nak3 pushed a commit to nak3/serving that referenced this pull request Apr 13, 2023
* Fix G112: Potential Slowloris Attacks lint errs (knative#13702)

* Fix queue proxy handler setup (knative#13815)

- single handlers are now assosciated with multiple servers
- main server is now shutdown
- metrics should work whether we receive requests on TLS or HTTP

---------

Co-authored-by: kmahapatra <kmahapatra@vmware.com>
Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
openshift-merge-robot pushed a commit to openshift-knative/serving that referenced this pull request Apr 13, 2023
* Fix G112: Potential Slowloris Attacks lint errs (knative#13702)

* Fix queue proxy handler setup (knative#13815)

- single handlers are now assosciated with multiple servers
- main server is now shutdown
- metrics should work whether we receive requests on TLS or HTTP

---------

Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: kmahapatra <kmahapatra@vmware.com>
Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants