Skip to content

fix route reconciler test flakes #13684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Feb 10, 2023
Merged

fix route reconciler test flakes #13684

knative-prow merged 1 commit into from
Feb 10, 2023

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Feb 9, 2023 •
edited
Loading

We were iterating of a go map - which isn't stable so the expected output can change

@knative-prow
Copy link

knative-prow bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 9, 2023
@knative-prow knative-prow bot requested review from KauzClay and jsanin-vmw February 9, 2023 21:57
@dprotaso
Copy link
Member Author

dprotaso commented Feb 9, 2023

/assign @psschwei

psschwei
psschwei reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Base: 86.22% // Head: 86.23% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (dd90f50) compared to base (729eb6d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13684      +/-   ##
==========================================
+ Coverage   86.22%   86.23%   +0.01%     
==========================================
  Files         197      197              
  Lines       14783    14774       -9     
==========================================
- Hits        12746    12740       -6     
+ Misses       1735     1733       -2     
+ Partials      302      301       -1
Impacted Files Coverage Δ
pkg/reconciler/route/resources/ingress.go 94.80% <100.00%> (-0.20%) ⬇️
pkg/reconciler/configuration/configuration.go 84.36% <0.00%> (+1.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow bot merged commit 2fc2a12 into knative:main Feb 10, 2023
@dprotaso dprotaso deleted the route-unit-flakes branch February 15, 2023 22:31
@dprotaso dprotaso mentioned this pull request Feb 27, 2023
Merged
@dprotaso
Copy link
Member Author

dprotaso commented Feb 27, 2023

/cherry-pick release-1.8

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 27, 2023

@dprotaso: #13684 failed to apply on top of branch "release-1.8":

Applying: fix route reconciler test flakes
Using index info to reconstruct a base tree...
M	pkg/reconciler/route/resources/ingress.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/route/resources/ingress.go
CONFLICT (content): Merge conflict in pkg/reconciler/route/resources/ingress.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix route reconciler test flakes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member Author

dprotaso commented Feb 27, 2023

/cherry-pick release-1.9

@knative-prow-robot knative-prow-robot mentioned this pull request Feb 27, 2023
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Feb 27, 2023

@dprotaso: new pull request created: #13753

Details

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsanin-vmw jsanin-vmw Awaiting requested review from jsanin-vmw

@KauzClay KauzClay Awaiting requested review from KauzClay

1 more reviewer

@psschwei psschwei psschwei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@psschwei psschwei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprotaso @knative-prow-robot @psschwei