Skip to content

[wip] test net-certmanager changes #13621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dprotaso wants to merge 11 commits into from
Closed

[wip] test net-certmanager changes #13621

dprotaso wants to merge 11 commits into from

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Jan 19, 2023

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 19, 2023
@knative-prow knative-prow bot requested review from andrew-su and vagababov January 19, 2023 21:18
@dprotaso dprotaso mentioned this pull request Jan 19, 2023
Merged
@codecov
Copy link

codecov bot commented Jan 19, 2023 •
edited
Loading

Codecov Report

Base: 86.17% // Head: 86.19% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (76e3bbd) compared to base (87f5b62).
Patch coverage: 88.23% of modified lines in pull request are covered.

❗ Current head 76e3bbd differs from pull request most recent head fafaf0d. Consider uploading reports for the commit fafaf0d to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13621      +/-   ##
==========================================
+ Coverage   86.17%   86.19%   +0.01%     
==========================================
  Files         197      197              
  Lines       14722    14727       +5     
==========================================
+ Hits        12687    12694       +7     
+ Misses       1734     1732       -2     
  Partials      301      301
Impacted Files Coverage Δ
pkg/reconciler/route/resources/ingress.go 95.00% <85.71%> (-1.19%) ⬇️
pkg/reconciler/domainmapping/resources/ingress.go 100.00% <100.00%> (ø)
pkg/reconciler/route/route.go 81.23% <0.00%> (+0.92%) ⬆️
pkg/autoscaler/scaling/multiscaler.go 88.59% <0.00%> (+1.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso
Copy link
Member Author

dprotaso commented Jan 19, 2023

/test all

@knative-prow knative-prow bot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Jan 20, 2023
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2023
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2023
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 20, 2023
@dprotaso dprotaso mentioned this pull request Jan 20, 2023
Merged
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2023
@vagababov
Copy link
Contributor

vagababov commented Jan 20, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 21, 2023

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2023
@dprotaso
Copy link
Member Author

dprotaso commented Jan 21, 2023

DNS record isn't setup correctly

@dprotaso
Copy link
Member Author

dprotaso commented Jan 22, 2023

/test istio-latest-no-mesh-tls_serving_main

@knative-prow knative-prow bot added the area/API API objects and controllers label Jan 22, 2023
@dprotaso dprotaso mentioned this pull request Jan 23, 2023
Closed
@knative-prow
Copy link

knative-prow bot commented Jan 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Jan 23, 2023
Merged
Merged
@dprotaso
Copy link
Member Author

dprotaso commented Jan 24, 2023

Going to close this out - I pulled the necessary changes into other PRs that have all merged.

@dprotaso dprotaso closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-su andrew-su Awaiting requested review from andrew-su

@vagababov vagababov Awaiting requested review from vagababov

Assignees

@vagababov vagababov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprotaso @vagababov @knative-prow-robot