Skip to content

Create image references properly#13408

Closed
upodroid wants to merge 2 commits intoknative:mainfrom
borg-land:generate-image-refs
Closed

Create image references properly#13408
upodroid wants to merge 2 commits intoknative:mainfrom
borg-land:generate-image-refs

Conversation

@upodroid
Copy link
Member

@upodroid upodroid commented Oct 18, 2022 •
edited
Loading

To enable signing images, ko has to write image references to imagerefs.txt so cosign can sign them. The flag set in knative/hack is being overridden and I forgot to check the nightlies.

/cc @knative/knative-release-leads

Proposed Changes

Release Note

NONE

@knative-prow knative-prow bot requested a review from a team October 18, 2022 12:52
@knative-prow
Copy link

knative-prow bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022 •
edited
Loading

Codecov Report

Base: 0.00% // Head: 86.47% // Increases project coverage by +86.47% 🎉

Coverage data is based on head (41aeb34) compared to base (6e597fa).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##           main   #13408       +/-   ##
=========================================
+ Coverage      0   86.47%   +86.47%     
=========================================
  Files         0      196      +196     
  Lines         0    14556    +14556     
=========================================
+ Hits          0    12588    +12588     
- Misses        0     1669     +1669     
- Partials      0      299      +299
Impacted Files Coverage Δ
pkg/http/response_recorder.go 100.00% <0.00%> (ø)
pkg/activator/handler/concurrency_reporter.go 89.92% <0.00%> (ø)
pkg/activator/handler/context.go 100.00% <0.00%> (ø)
pkg/reconciler/route/reconcile_resources.go 78.03% <0.00%> (ø)
pkg/reconciler/autoscaling/hpa/controller.go 100.00% <0.00%> (ø)
pkg/reconciler/metric/controller.go 100.00% <0.00%> (ø)
pkg/reconciler/autoscaling/kpa/metrics.go 94.11% <0.00%> (ø)
pkg/queue/health/handler.go 100.00% <0.00%> (ø)
.../reconciler/domainmapping/resources/domainclaim.go 100.00% <0.00%> (ø)
pkg/queue/sharedmain/main.go 0.61% <0.00%> (ø)
... and 186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@upodroid
Copy link
Member Author

upodroid commented Oct 18, 2022

/hold

There is a bug in ko and i'll need to defer this for next release :(

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2022
@upodroid
Copy link
Member Author

upodroid commented Oct 18, 2022 

gcr.io/knative-nightly/knative.dev/serving/cmd/autoscaler-hpa@sha256:4d0cc13707d74a64996276c64632a0a593f30ddb45b8ab47ec930869b9f949ed
c32b25dfed82113e0
ive.dev/serving/cmd/domain-mapping-webhook@sha256:a141d35a3b108e3469865f90e8f93bca70c71b84298e6bc11d148ff773e5e0e2
gcr.io/knative-nightly/knative.dev/serving/cmd/domain-mapping@sha256:fdd73d396f8b2ca083b2b9e20219b7fa9235b91ee99ac7c986ef12adf0635f1a
gcr.io/knative-nightly/knative.dev/serving/cmd/autoscaler@sha256:b3c09a564816ffee2373d1b17a9f9901c25c8c24a24c36e198a627632c4db408
gcr.io/knative-nightly/knative.dev/serving/cmd/activator@sha256:da1c5c4d79d1edbf23bd99f1c43dfd01c19d99388b02e62bb66b5827b6f2c503
gcr.io/knative-nightly/knative.dev/serving/cmd/webhook@sha256:24793296673ab5fd1618713d910b8bf0befaa6409ea625a7dd5abfcd68fb468b
gcr.io/knative-nightly/knative.dev/serving/cmd/controller@sha256:7ff860da8f3090840c34e33bdb117703526bcaff9dc3d351d9d1b9c89b5733b4

ko isn't outputting image refs cleanly

@upodroid
Copy link
Member Author

upodroid commented Oct 18, 2022

/hold cancel

Can we get this in? I fixed it.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 18, 2022
@imjasonh imjasonh mentioned this pull request Oct 18, 2022
Merged
@upodroid
Copy link
Member Author

upodroid commented Oct 18, 2022

/test istio-latest-no-mesh

@dprotaso
Copy link
Member

dprotaso commented Oct 20, 2022

I wonder if it's simpler to parse image refs from cat'ing the files in YAML_LIST_FILE and filtering with a regexp that has KO_DOCKER_REPO as a prefix

That would scale better and shouldn't require changes each repos generate-yamls.sh

@upodroid
Copy link
Member Author

upodroid commented Oct 20, 2022

I haven't thought of that.

I'll try that out

This patch is needed for serving, eventing and eventing-kafka so far.

This was referenced Nov 14, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@upodroid @dprotaso