Allow setting seccompProfile to enable using restricted security profile #13401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportBase: 86.52% // Head: 86.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13401 +/- ##
==========================================
- Coverage 86.52% 86.45% -0.07%
==========================================
Files 196 196
Lines 14551 14556 +5
==========================================
- Hits 12590 12585 -5
- Misses 1662 1671 +9
- Partials 299 300 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
Author
psschwei
reviewed
Oct 18, 2022
Member
psschwei
left a comment
There was a problem hiding this comment.
One minor nit: we should also edit the features configmap to include this as one of the fields that can be set when the gate is on. Otherwise, looks good to me
skonto
pushed a commit
to skonto/serving
that referenced
this pull request
Oct 19, 2022
openshift-merge-robot
pushed a commit
to openshift/knative-serving
that referenced
this pull request
Oct 24, 2022
…restricted security profile (#1284) * Allow setting seccompProfile to enable using restricted security profile (knative#13401) * fix features cm Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
skonto
pushed a commit
to skonto/serving
that referenced
this pull request
Nov 15, 2022
…restricted security profile (knative#1284) * Allow setting seccompProfile to enable using restricted security profile (knative#13401) * fix features cm Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
openshift-merge-robot
pushed a commit
to openshift-knative/serving
that referenced
this pull request
Nov 15, 2022
…restricted security profile (#1284) (#9) * Allow setting seccompProfile to enable using restricted security profile (knative#13401) * fix features cm Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
openshift-merge-robot
pushed a commit
to openshift-knative/serving
that referenced
this pull request
Dec 22, 2022
#91) * [RELEASE-1.5][BACKPORT] Allow setting seccompProfile to enable using restricted security profile (#1284) (#9) * Allow setting seccompProfile to enable using restricted security profile (knative#13401) * fix features cm Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com> * Update checksum Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com> Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
wmfgerrit
pushed a commit
to wikimedia/operations-docker-images-production-images
that referenced
this pull request
Feb 3, 2025
The commit knative/serving#13401 allows pods scheduled/created via knative-serving to be set with a seccomp profile, required by the PSS migration to allow running pods in the "restricted" security realm. The commit knative/serving#13398 adds a config-map flag to inject secure defaults for pods not running with specific settings, to allow the PSS restricted profile. Bug: T369493 Change-Id: Ib2ec22d4ccdeebda3ba775bdcd3d4e1be520f7ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13398
seccompProfile.typeshould only be set toRuntimeDefaultorLocalhostin therestrictedPod Security Standard.Allow users to set the
seccompProfileso that they can run Knative user-containers in restricted mode.Relates to #13376
Proposed Changes
seccompProfilein PodSecurityContext and SecurityContextRelease Note