Skip to content

Fix ingress timeout detection in "hello world" shell test. #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
google-prow-robot merged 1 commit into from
Jun 19, 2018
Merged

Fix ingress timeout detection in "hello world" shell test. #1272

google-prow-robot merged 1 commit into from
Jun 19, 2018

Conversation

@adrcunha
Copy link
Contributor

@adrcunha adrcunha commented Jun 19, 2018 •
edited
Loading

$service_host contains an error message, thus failure checking must assert against $service_ip being empty as well, just like the opposite check in line 163.

@adrcunha adrcunha requested review from bobcatfish and jessiezcc June 19, 2018 15:15
@google-prow-robot google-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2018
@adrcunha
Copy link
Contributor Author

adrcunha commented Jun 19, 2018

/test pull-knative-serving-integration-tests

@adrcunha adrcunha mentioned this pull request Jun 19, 2018
Closed
@bobcatfish
Copy link
Contributor

bobcatfish commented Jun 19, 2018

Is it possible to update the commit message to explain what needed to be fixed? (e.g. why it wasn't working before)

/hold
/lgtm
/approve
/meow space

@google-prow-robot
Copy link

google-prow-robot commented Jun 19, 2018

@bobcatfish: cat image

Details

In response to this:

Is it possible to update the commit message to explain what needed to be fixed? (e.g. why it wasn't working before)

/hold
/lgtm
/approve
/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-prow-robot google-prow-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 19, 2018
@google-prow-robot
Copy link

google-prow-robot commented Jun 19, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adrcunha
Copy link
Contributor Author

adrcunha commented Jun 19, 2018

Done.

@adrcunha
Copy link
Contributor Author

adrcunha commented Jun 19, 2018

/hold cancel

@google-prow-robot google-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2018
@google-prow-robot google-prow-robot merged commit add1600 into knative:master Jun 19, 2018
nak3 pushed a commit to nak3/serving that referenced this pull request Oct 27, 2022
[RELEASE-1.5] [BACKPORT] Fix sc for psp compliance (knative#1272)
3357b75 
* Fix psp in config manifests  (knative#13327)

* fix sc

* revert github flow change

* remove seccomp profile

* fix indentation

* fix deployments scs for ci and release
skonto pushed a commit to skonto/serving that referenced this pull request Nov 15, 2022
@skonto
[RELEASE-1.5] [BACKPORT] Fix sc for psp compliance (knative#1272)
bea0d55 
* Fix psp in config manifests  (knative#13327)

* fix sc

* revert github flow change

* remove seccomp profile

* fix indentation

* fix deployments scs for ci and release
openshift-merge-robot referenced this pull request in openshift-knative/serving Nov 15, 2022
@skonto
[RELEASE-1.5] [BACKPORT] Fix sc for psp compliance (#1272) (#12)
9628e22 
* Fix psp in config manifests  (knative#13327)

* fix sc

* revert github flow change

* remove seccomp profile

* fix indentation

* fix deployments scs for ci and release
openshift-merge-robot referenced this pull request in openshift-knative/serving Nov 18, 2022
@openshift-cherrypick-robot
Fix sc for psp compliance (#1272) (#14)
19a4b24 
* Fix psp in config manifests  (knative#13327)

* fix sc

* revert github flow change

* remove seccomp profile

* fix indentation

* fix deployments scs for ci and release

Co-authored-by: Stavros Kontopoulos <skontopo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@jessiezcc jessiezcc Awaiting requested review from jessiezcc

Assignees

@bobcatfish bobcatfish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrcunha @bobcatfish @google-prow-robot