Skip to content

[release-1.7] Fix nil pointer deref in drain when it's reset #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
knative-prow-robot wants to merge 2 commits into from
Closed

[release-1.7] Fix nil pointer deref in drain when it's reset #2647

knative-prow-robot wants to merge 2 commits into from

Conversation

@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Nov 22, 2022

This is an automated cherry-pick of #2645

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 22, 2022
Merged
@knative-prow
Copy link

knative-prow bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-prow-robot
Once this PR has been reviewed and has the lgtm label, please assign tcnghia for approval by writing /assign @tcnghia in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 81.37% // Head: 81.34% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (393fba4) compared to base (3b65316).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.7    #2647      +/-   ##
===============================================
- Coverage        81.37%   81.34%   -0.04%     
===============================================
  Files              162      162              
  Lines             9736     9736              
===============================================
- Hits              7923     7920       -3     
- Misses            1577     1579       +2     
- Partials           236      237       +1
Impacted Files Coverage Δ
network/handlers/drain.go 97.14% <100.00%> (ø)
apis/duck/cached.go 91.89% <0.00%> (-8.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso dprotaso closed this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@knative-prow-robot @dprotaso