Skip to content

Improve func deploy UX by checking function existence before prompting #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 4 commits into from
Sep 17, 2025
Merged

Improve func deploy UX by checking function existence before prompting #3042

knative-prow merged 4 commits into from
Sep 17, 2025

Conversation

@RayyanSeliya
Copy link
Contributor

@RayyanSeliya RayyanSeliya commented Sep 15, 2025

Changes

  • 🧹 Fix confusing UX flow in func deploy when no function exists
  • 🧹 Check function initialization before prompting for registry configuration
  • 🧹 Provide educational error message with workflow guidance and help pointer

/kind enhancement

Fixes #3041

Previously, func deploy would prompt for registry info even when no function existed,
forcing users to cancel manually before seeing the real error. Now it immediately shows
clear guidance on how to create and deploy functions properly.

Release Note

Improve func deploy user experience by showing clear error guidance immediately when run outside a function directory, instead of prompting for registry configuration first.

@RayyanSeliya
Improve the user experience by checking function existence before pro…
dd7c94b 
…mpting for deployment configuration

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Sep 15, 2025

Hi @RayyanSeliya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2025
@codecov
Copy link

codecov bot commented Sep 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 34.48276% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.38%. Comparing base (11f389b) to head (5a6c3be).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/deploy.go 34.48% 17 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3042      +/-   ##
==========================================
+ Coverage   58.67%   59.38%   +0.70%     
==========================================
  Files         133      133              
  Lines       17027    17044      +17     
==========================================
+ Hits         9991    10121     +130     
+ Misses       6106     5964     -142     
- Partials      930      959      +29
Flag Coverage Δ
e2e-tests 40.88% <24.13%> (+1.45%) ⬆️
integration-tests 54.09% <34.48%> (+1.66%) ⬆️
unit-tests 46.30% <34.48%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gauron99
gauron99 requested changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks a lot for the contribution! just a few nits from me

@gauron99
Copy link
Contributor

gauron99 commented Sep 16, 2025

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2025
@RayyanSeliya
Improve the description formatting using backticks
d26b525 
Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>
@RayyanSeliya
fix the linter issues
c4fac72 
Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>
@RayyanSeliya
update component versions failing ci test
5a6c3be 
Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>
@gauron99
Copy link
Contributor

gauron99 commented Sep 17, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, RayyanSeliya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@knative-prow knative-prow bot merged commit 7353e13 into knative:main Sep 17, 2025
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gauron99 gauron99 gauron99 requested changes

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@gauron99 gauron99

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confusing UX: func deploy prompts for registry before checking if function exists

2 participants

@RayyanSeliya @gauron99