Skip to content

Improve error message when func subscribe is run outside function directory #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Sep 8, 2025
Merged

Improve error message when func subscribe is run outside function directory #3025

knative-prow merged 1 commit into from
Sep 8, 2025

Conversation

@RayyanSeliya
Copy link
Contributor

@RayyanSeliya RayyanSeliya commented Sep 6, 2025

Changes

  • 🧹 Update error message shown when func subscribe is run outside a function directory.
  • Made the message more user-friendly and easier for beginners to understand.
  • Replaced cryptic technical error with clear, actionable guidance.
  • Provides context-specific information about event subscription workflow.

/kind enhancement

Fixes #3024

Release Note

Improve error message when `func subscribe` is run outside function directory
to be more beginner-friendly and provide clear guidance on creating functions
before subscribing to events.

@RayyanSeliya
improve the error handling for subscribe command when outside the fun…
a4fb4e2 
…ction directory

Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Sep 6, 2025

Hi @RayyanSeliya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2025
@codecov
Copy link

codecov bot commented Sep 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.42%. Comparing base (cd6c388) to head (a4fb4e2).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/subscribe.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3025      +/-   ##
==========================================
+ Coverage   58.66%   59.42%   +0.76%     
==========================================
  Files         133      133              
  Lines       17030    17027       -3     
==========================================
+ Hits         9991    10119     +128     
+ Misses       6108     5950     -158     
- Partials      931      958      +27
Flag Coverage Δ
e2e-tests 40.77% <0.00%> (+1.34%) ⬆️
integration-tests 54.09% <0.00%> (+1.64%) ⬆️
unit-tests 46.33% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland lkingland added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 8, 2025
lkingland
lkingland approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for the improved error message

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, RayyanSeliya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025
@knative-prow knative-prow bot merged commit 2f22a0b into knative:main Sep 8, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkingland lkingland lkingland approved these changes

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@lkingland lkingland

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cryptic error message from func subscribe when no function is found in current directory

2 participants

@RayyanSeliya @lkingland