Skip to content

improve error message for func run making it more beginner friendly #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 3 commits into from
Sep 24, 2025
Merged

improve error message for func run making it more beginner friendly #3022

knative-prow merged 3 commits into from
Sep 24, 2025

Conversation

@RayyanSeliya
Copy link
Contributor

@RayyanSeliya RayyanSeliya commented Sep 5, 2025

Changes

  • 🧹 Update error message shown when func run is run outside a function directory.
  • Made the message more user-friendly and easier for beginners to understand.
  • Added step-by-step workflow guidance with examples for both new and existing functions.
  • Provides context-specific guidance that func run runs functions locally for testing.

/kind enhancement

Fixes #3021

Release Note

Improve error message when `func run` is run outside function directory
to be more beginner-friendly, include step-by-step workflow guidance, and 
explain that func run is used for local testing.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 5, 2025

Hi @RayyanSeliya. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Sep 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.37%. Comparing base (11f389b) to head (66b2d6a).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cmd/run.go 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3022      +/-   ##
==========================================
+ Coverage   58.67%   59.37%   +0.69%     
==========================================
  Files         133      133              
  Lines       17027    17037      +10     
==========================================
+ Hits         9991    10116     +125     
+ Misses       6106     5962     -144     
- Partials      930      959      +29
Flag Coverage Δ
e2e-tests 40.74% <0.00%> (+1.31%) ⬆️
integration-tests 54.08% <0.00%> (+1.65%) ⬆️
unit-tests 46.29% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lkingland
lkingland approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, RayyanSeliya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 16, 2025

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2025
@RayyanSeliya
update component versions failing ci test
66b2d6a 
Signed-off-by: RayyanSeliya <rayyanseliya786@gmail.com>
@lkingland lkingland added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2025
@knative-prow knative-prow bot merged commit dd1cdf7 into knative:main Sep 24, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@lkingland lkingland Awaiting requested review from lkingland

Assignees

@lkingland lkingland

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unclear instructions from func run when no function is found in current directory

2 participants

@RayyanSeliya @lkingland