Skip to content

Cleanup: Remove container flag & make the builder dynamic (var II) #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gauron99 wants to merge 1 commit into from
Closed

Cleanup: Remove container flag & make the builder dynamic (var II) #2983

gauron99 wants to merge 1 commit into from

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Aug 13, 2025 •
edited
Loading

Variant II

  • This version creates a dynamic builder which prefers host builder instead of pack wherever possible, that means when a runtime has an oci builder.
  • These changes are more complex and reaching greater multitude of systems, including changing some default behavior of current implementations and their respective tests in comparison to variant I.
  • With this variant, upon creating oci builder for a new runtime would immediately prefer the host builder by default making the adoption and transition easier.
  • The current "non standard" implementations could be reversed once the host builder becomes the standard default.

Changes

  • 🧹 Remove the --container flag
  • now the logic in run cmd uses the current builder
  • assign host builder as default (not only for run) if runtime supports it, otherwise pack
  • builder determination now depends on runtime

/kind cleanup
Fixes #2973

Release Note

Remove the --container flag - builds are determined via builder dynamically; Default to 'host' for oci-supported runtimes

Docs

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 13, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 13, 2025
@gauron99 gauron99 marked this pull request as draft August 13, 2025 08:38
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2025
@codecov
Copy link

codecov bot commented Aug 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 73.91304% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.68%. Comparing base (e4bd40b) to head (4ca5896).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/root.go 52.63% 6 Missing and 3 partials ⚠️
cmd/run.go 83.78% 3 Missing and 3 partials ⚠️
cmd/deploy.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2983      +/-   ##
==========================================
+ Coverage   58.95%   59.68%   +0.72%     
==========================================
  Files         132      132              
  Lines       16944    16936       -8     
==========================================
+ Hits         9990    10108     +118     
+ Misses       6025     5866     -159     
- Partials      929      962      +33
Flag Coverage Δ
e2e-tests 44.30% <71.01%> (+4.66%) ⬆️
integration-tests 54.36% <73.91%> (+1.55%) ⬆️
unit-tests 46.55% <73.91%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-zkpzotpnptou branch 2 times, most recently from 1defaea to 859bcf7 Compare August 15, 2025 04:20
@gauron99 gauron99 changed the title Cleanup: Remove container flag for func run Cleanup: Remove container flag for func run (var I) Aug 15, 2025
@gauron99 gauron99 changed the title Cleanup: Remove container flag for func run (var I) Cleanup: Remove container flag & make the builder dynamic (var I) Aug 15, 2025
@gauron99 gauron99 changed the title Cleanup: Remove container flag & make the builder dynamic (var I) Cleanup: Remove container flag & make the builder dynamic (var II) Aug 15, 2025
@knative knative deleted a comment from knative-prow bot Aug 15, 2025
@gauron99 gauron99 mentioned this pull request Aug 18, 2025
Merged
@gauron99
Copy link
Contributor Author

gauron99 commented Aug 20, 2025

Closing this in favor of variant I #2987

@gauron99 gauron99 closed this Aug 20, 2025
@gauron99 gauron99 deleted the push-zkpzotpnptou branch August 20, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improvement: Reduce complexity of container and builder flag

1 participant

@gauron99