Skip to content

Conversation

@lkingland
Copy link
Member

Adds the --address flag to func run

/kind enhancement

func run now supports the --address flag

@knative-prow knative-prow bot requested review from dsimansk and vyasgun June 25, 2025 03:31
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2025
@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 64.58333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 62.55%. Comparing base (1cccfd3) to head (a6a99f0).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pkg/docker/runner.go 55.55% 5 Missing and 3 partials ⚠️
pkg/functions/runner.go 53.84% 5 Missing and 1 partial ⚠️
pkg/mock/runner.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2887      +/-   ##
==========================================
+ Coverage   57.96%   62.55%   +4.58%     
==========================================
  Files         129      129              
  Lines       15767    15872     +105     
==========================================
+ Hits         9140     9929     +789     
+ Misses       5785     4998     -787     
- Partials      842      945     +103     
Flag Coverage Δ
e2e-tests 43.09% <66.66%> (+7.90%) ⬆️
integration-tests 48.75% <39.58%> (?)
unit-tests 48.87% <47.91%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkingland lkingland force-pushed the push-tuxtnkyxksqq branch from d82d1e7 to c8c9daf Compare June 25, 2025 03:53
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2025
@lkingland lkingland force-pushed the push-tuxtnkyxksqq branch 3 times, most recently from d68ea2a to 3d6ad34 Compare June 26, 2025 03:51
@lkingland lkingland force-pushed the push-tuxtnkyxksqq branch from 3d6ad34 to a6a99f0 Compare June 26, 2025 03:55
of the container even if no filesysem changes are detected
$ {{rootCmdUse}} run --build
o Run the function locally on the host with no containerization (Go only).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OT: this can be expanded right?

Suggested change
o Run the function locally on the host with no containerization (Go only).
o Run the function locally on the host with no containerization (Go & Python only).

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2025
@knative-prow
Copy link

knative-prow bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gauron99
Copy link
Contributor

/retest

@knative-prow knative-prow bot merged commit e8ccb1b into knative:main Jun 27, 2025
39 checks passed
@lkingland lkingland deleted the push-tuxtnkyxksqq branch June 30, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants