Skip to content

Make docker.io/heroku/ builders trusted #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Apr 30, 2025
Merged

Make docker.io/heroku/ builders trusted #2818

knative-prow merged 1 commit into from
Apr 30, 2025

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Apr 29, 2025 •
edited
Loading

Make heroku's builders trusted.

fixes #2516

feat: make heroku's builders trusted

@knative-prow knative-prow bot requested review from dsimansk and nainaz April 29, 2025 17:59
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2025
@codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.41%. Comparing base (de6022b) to head (7488725).
Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (de6022b) and HEAD (7488725). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (de6022b) HEAD (7488725)
unit-tests-macos-latest 1 0
unit-tests-ubuntu-latest 1 0
e2e-test 1 0
unit-tests-windows-latest 1 0
integration-tests 1 0
e2e-test-oncluster 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2818       +/-   ##
===========================================
- Coverage   61.59%   48.41%   -13.18%     
===========================================
  Files         131      129        -2     
  Lines       15794    15785        -9     
===========================================
- Hits         9728     7643     -2085     
- Misses       5155     7455     +2300     
+ Partials      911      687      -224
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster ?
integration-tests ?
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matejvasek matejvasek requested review from gauron99, lkingland and matzew and removed request for dsimansk and nainaz April 29, 2025 18:15
@matejvasek
Copy link
Contributor Author

matejvasek commented Apr 29, 2025

PTAL @lkingland @gauron99 @matzew

@matejvasek
Copy link
Contributor Author

matejvasek commented Apr 29, 2025

@lkingland @matzew plz override "codecov/project", it's failing probably because I created the PR via github web UI and therefore in the repository (not in fork).

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2025
@gauron99
Copy link
Contributor

gauron99 commented Apr 30, 2025

/override codecov/project

@knative-prow
Copy link

knative-prow bot commented Apr 30, 2025

@gauron99: Overrode contexts on behalf of gauron99: codecov/project

Details

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauron99
Copy link
Contributor

gauron99 commented Apr 30, 2025

codecov is failing because the PR is created in the base repo, not a fork... therefore the permissions are different and tokenless upload doesnt work

@knative-prow
Copy link

knative-prow bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit c6c6aa2 into main Apr 30, 2025
45 of 46 checks passed
@gauron99
Copy link
Contributor

gauron99 commented Apr 30, 2025

/cherry-pick release-1.18

@knative-prow-robot
Copy link

knative-prow-robot commented Apr 30, 2025

@gauron99: new pull request created: #2823

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Apr 30, 2025
Merged
@matejvasek matejvasek deleted the matejvasek-trust-heroku branch December 16, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gauron99 gauron99 gauron99 approved these changes

@lkingland lkingland lkingland approved these changes

@matzew matzew Awaiting requested review from matzew

Assignees

@gauron99 gauron99

@lkingland lkingland

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

func can't build with untrusted builder image

5 participants

@matejvasek @gauron99 @knative-prow-robot @lkingland