Skip to content

Injected tracing headers into jobsink event file #8626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Aug 6, 2025
Merged

Injected tracing headers into jobsink event file #8626

knative-prow merged 1 commit into from
Aug 6, 2025

Conversation

@cobyge
Copy link
Contributor

@cobyge cobyge commented Jul 13, 2025

Fixes #8607
Hey! I finally got around to implementing what we talked about in the issue above.

Please tell me if I should move the implementation of PopulateCEDistributedTracing. I just looked around until I found something similar enough, and put the code right next to it.

This currently only injects the headers into Jobsink events, are there any other places where events are propagated without http, and could benefit from this?
Let me know if you need any more changes 😄

Proposed Changes

  • 🎁 Inject tracing headers into cloudevent according to the spec

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior - Does this need to be done?
  • Docs PR for any user-facing impact - Does this need to be done?
  • Spec PR for any new API feature - Not relevant
  • Conformance test for any change to the spec - Not relevant

Release Note

Event files received by Jobsinks will now include the Distributed Tracing extension

Docs

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 13, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cobyge / name: Coby Geralnik (cf2a340)

@knative-prow
Copy link

knative-prow bot commented Jul 13, 2025

Welcome @cobyge! It looks like this is your first PR to knative/eventing 🎉

@knative-prow
Copy link

knative-prow bot commented Jul 13, 2025

Hi @cobyge. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2025
@knative-prow knative-prow bot requested review from Leo6Leo and pierDipi July 13, 2025 23:05
@Cali0707 Cali0707 self-requested a review July 14, 2025 13:33
Cali0707
Cali0707 reviewed Jul 14, 2025
View reviewed changes
@cobyge cobyge requested a review from Cali0707 July 14, 2025 14:02
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2025
@Cali0707
Copy link
Member

Cali0707 commented Jul 17, 2025

Hey @cobyge with #8639 merged the JobSink should be configurable with config-observability, and will expose some metrics through otel. If you rebase your PR here and include the OTel-specific tracing work that would be awesome

@cobyge cobyge closed this Jul 17, 2025
@cobyge cobyge force-pushed the jobsink-inject-tracing branch from 66e1222 to c9821a9 Compare July 17, 2025 17:39
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 17, 2025
@cobyge cobyge reopened this Jul 17, 2025
@knative-prow-robot knative-prow-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 17, 2025
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2025
@cobyge
Copy link
Contributor Author

cobyge commented Jul 17, 2025

@Cali0707 fixed, ready for a new review :)

@codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.08%. Comparing base (c9821a9) to head (cf2a340).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/tracing/populate_ce_distributed_tracing.go 56.52% 10 Missing ⚠️
cmd/jobsink/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8626      +/-   ##
==========================================
+ Coverage   52.07%   52.08%   +0.01%     
==========================================
  Files         401      402       +1     
  Lines       25250    25273      +23     
==========================================
+ Hits        13148    13164      +16     
- Misses      11312    11320       +8     
+ Partials      790      789       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coby-astsec
Copy link

coby-astsec commented Aug 1, 2025 •
edited
Loading

Hey, any chance I could get this re-reviewed?

@pierDipi
Copy link
Member

pierDipi commented Aug 6, 2025

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2025
Cali0707
Cali0707 reviewed Aug 6, 2025
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cobyge sorry for the delay here! This looks great, thanks for working on it

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, cobyge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@Cali0707
Copy link
Member

Cali0707 commented Aug 6, 2025

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Aug 6, 2025

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 96629b6 into knative:main Aug 6, 2025
63 checks passed
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Aug 6, 2025

@Cali0707: new pull request created: #8657

Details

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 6, 2025
Merged
Cali0707 pushed a commit to Cali0707/eventing that referenced this pull request Aug 11, 2025
@cobyge @Cali0707
Injected tracing headers into jobsink event file (knative#8626)
5266b93
@Cali0707 Cali0707 mentioned this pull request Aug 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cali0707 Cali0707 Cali0707 left review comments

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pass opentelemetry tracing context to jobsink

5 participants

@cobyge @Cali0707 @coby-astsec @pierDipi @knative-prow-robot