Skip to content

[release-1.17] Migrate golanglint-ci config to v2 #8563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Apr 15, 2025
Merged

[release-1.17] Migrate golanglint-ci config to v2 #8563

knative-prow merged 1 commit into from
Apr 15, 2025

Conversation

@creydr
Copy link
Member

@creydr creydr commented Apr 15, 2025

Manual backport of #8557

@creydr creydr requested a review from matzew April 15, 2025 06:02
@knative-prow knative-prow bot requested review from aliok and lionelvillard April 15, 2025 06:02
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2025
@creydr creydr mentioned this pull request Apr 15, 2025
Merged
@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.12%. Comparing base (4e48320) to head (298d841).
Report is 1 commits behind head on release-1.17.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.17    #8563   +/-   ##
=============================================
  Coverage         52.12%   52.12%           
=============================================
  Files               388      388           
  Lines             23414    23414           
=============================================
  Hits              12205    12205           
  Misses            10474    10474           
  Partials            735      735

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

matzew
matzew approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
@knative-prow
Copy link

knative-prow bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d01256f into knative:release-1.17 Apr 15, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@creydr @matzew