Skip to content

[release-1.17] Compare the entire PodTemplateSpec, instead of just its PodSpec #8560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Apr 15, 2025
Merged

[release-1.17] Compare the entire PodTemplateSpec, instead of just its PodSpec #8560

knative-prow merged 1 commit into from
Apr 15, 2025

Conversation

@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Apr 14, 2025

This is an automated cherry-pick of #8558

ContainerSource now compares the entire PodTemplateSpec, instead of just its PodSpec. This avoids loosing edits on metadata, like annotations

@knative-prow-robot knative-prow-robot mentioned this pull request Apr 14, 2025
Merged
5 tasks
@knative-prow knative-prow bot requested review from aliok and matzew April 14, 2025 18:09
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2025
@codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.11%. Comparing base (d01256f) to head (b82691e).
Report is 1 commits behind head on release-1.17.

Files with missing lines Patch % Lines
pkg/reconciler/containersource/containersource.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.17    #8560      +/-   ##
================================================
- Coverage         52.12%   52.11%   -0.01%     
================================================
  Files               388      388              
  Lines             23414    23416       +2     
================================================
- Hits              12205    12204       -1     
- Misses            10474    10477       +3     
  Partials            735      735

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@creydr
Copy link
Member

creydr commented Apr 15, 2025

Codestyle action probably needs #8563

@matzew
Compare the entire PodTemplateSpec, instead of just its PodSpec
b82691e 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the cherry-pick-8558-to-release-1.17 branch from 232d7ac to b82691e Compare April 15, 2025 07:09
matzew
matzew approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
@knative-prow
Copy link

knative-prow bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@matzew
Copy link
Member

matzew commented Apr 15, 2025

/retest

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/override "codecov/project"

@knative-prow
Copy link

knative-prow bot commented Apr 15, 2025

@matzew: Overrode contexts on behalf of matzew: codecov/project

Details

In response to this:

/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/override "codecov/project"

@knative-prow
Copy link

knative-prow bot commented Apr 15, 2025

@matzew: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • codecov/project

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-tests_eventing_release-1.17
  • conformance-tests_eventing_release-1.17
  • reconciler-tests_eventing_release-1.17
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_eventing_release-1.17
  • upgrade-tests_eventing_release-1.17

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit eb58703 into knative:release-1.17 Apr 15, 2025
24 of 25 checks passed
creydr pushed a commit to creydr/knative-eventing that referenced this pull request Sep 29, 2025
@knative-prow-robot @matzew @creydr
[release-1.17] Compare the entire PodTemplateSpec, instead of just it…
b8c56d7 
…s PodSpec (knative#8560)

Compare the entire PodTemplateSpec, instead of just its PodSpec

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
@creydr creydr mentioned this pull request Sep 29, 2025
Merged
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Sep 30, 2025
@creydr @knative-prow-robot
@pierDipi @matzew
[release-v1.17] Add missing backports (#1674)
934c456 
* [release-1.17] Reduce mt-broker-controller memory usage with namespaced endpoint informer (knative#8421)

* Reduce mt-broker-controller memory usage with namespaced endpoint informer

Currently, the mt-broker-controller is using a cluster-wide endpoints
informer but it actually only uses endpoints in the "SYSTEM_NAMESPACE".

Using the namespaced informer factory ensures that the watcher
is only watching endpoints in the `knative-eventing` (also known as
`SYSTEM_NAMESPACE`) namespace.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Start informer

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* [release-1.17] Scheduler: Resync reserved periodically to keep state consistent (knative#8453)

Scheduler: Resync reserved periodically to keep state consistent

Add resyncReserved removes deleted vPods from reserved to keep the
state consistent when leadership changes (Promote / Demote).

`initReserved` is not enough since the vPod lister can be stale.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* [release-1.17] Scheduler: log expected vreplicas by vpod (knative#8462)

Scheduler: log expected vreplicas by vpod

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* [release-1.17] Compare the entire PodTemplateSpec, instead of just its PodSpec (knative#8560)

Compare the entire PodTemplateSpec, instead of just its PodSpec

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>

* [release-1.17] Fix hardcoded knative-eventing namespace (knative#8577)

* dizzy: Remove hard-coded knative-eventing namespace and replace with system.Namespace() and touch test to get that properly injected

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* broom: Remove yet another hard-coded instance of knative-eventing

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>

* [release-1.17] Guard reserved access with lock and create vpods in tests (knative#8504)

* Guard reserved access with lock in tests

* Create vpods in test

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knative-prow-robot @creydr @matzew