Skip to content

Conversation

@pierDipi
Copy link
Member

@pierDipi pierDipi commented Feb 18, 2025

Inject tracing configurations to Jsonata deployment

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 18, 2025
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the event-transform-tracing branch from 4de8dd0 to e2651fe Compare February 25, 2025 07:38
@pierDipi pierDipi changed the title [WIP] EventTransform: Inject tracing configurations EventTransform: Inject tracing configurations Feb 25, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2025
@pierDipi
Copy link
Member Author

/test unit-tests

@pierDipi
Copy link
Member Author

/cc @matzew

@knative-prow knative-prow bot requested a review from matzew February 25, 2025 10:52
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3153b47 into knative:main Feb 26, 2025
29 of 35 checks passed
matzew pushed a commit to matzew/eventing that referenced this pull request Mar 18, 2025
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
matzew pushed a commit to matzew/eventing that referenced this pull request Mar 19, 2025
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Mar 21, 2025
* Partial implementation of certmanager for integration sink (knative#8481)

* Adding cert-mananger bits
Basics for Cert-manager

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding create cert manifest function

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Use the make cert

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Reconcile Certificate manifest and add RBAC

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add secret filter to controller

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Look up secrets/certs for sink

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Remove old/wrong Certificate manifest and reference

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Fix controller compile

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Formatting

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* change the reconcile of cert manifest, and run it only w/ some form of TLS

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* using filtered informer

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding Rekt test for IntegrationSink TLS support

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* adding a bit of https port for deployment/service of the IntegrationSink

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Mounting secrets and setting quarkus env vars for TLS support

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding flags for different TLS levels resulting in diffeerent quarkus env vars

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Remove bad comment

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding label

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update codegen

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Disable tmp. the cert manager feature

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Fixing header/year

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* More test tweaking

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Remove unused and comment out the hooks for now

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Run make generate-release

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Remove unused code (knative#8485)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* IntegrationSink prefactors (knative#8486)

Little refactors on IntegrationSink

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add initial iteration of eventing-integration resources (knative#8493)

* Generic code for Certificates (knative#8489)

Make Certifacte factory more generic

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Jsonata Event transform e2e tests (knative#8499)

* E2E tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* EventTransform Jsonata e2e tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Use eventing-integrations images and fix tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Verify response status code received by source

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Update JSONata transformations

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Inject integration images from ConfigMap (knative#8500)

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Run make generate-release

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update to the correct file (knative#8507)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* EventTransform: Inject tracing configurations (knative#8479)

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* EventTransform: add reconciler unit tests (knative#8513)

* EventTransform: add reconciler unit tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Update pkg/reconciler/testing/v1alpha1/eventtransform.go

Co-authored-by: Marek Schmidt <maschmid@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Marek Schmidt <maschmid@redhat.com>

* Enable Cert Manager (knative#8509)

* Re-enable Cert Mgr

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Manual informer

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update main

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* update controller

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Adding label on cert

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* add enqueue

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Create Cert Informer, on demand, and cancle when flag is disabled

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Update unit tests that broke during rrefactors

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Event Transform JSONata TLS (knative#8515)

* Event Transform JSONata TLS

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* HA and security context

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Reconcile Certificate

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Additional unit tests cases

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Fix tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* EventTransform trust bundle propagation and tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Fix tests and address comments

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Run make generate-release

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add dynamic cert-manager certificates informer (knative#8517)

* Add dynamic informer, part I

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add Dynamic certificates informer for EventTransform

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add Dynamic certificates Informer to IntegrationSink

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Fix error message

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Improve CM Cert reconcile and deletion if feature is turned off (knative#8519)

refactor CM Cert reconciler and take care of delete if feature is disabled

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Remove transformations and integrations ConfigMaps (#1201)

We don't use the ConfigMaps to inject the values, the operator
will replace the value to the images directly.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Run make generate-release

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Add configmaps/finalizers permissions

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add update finalizers permissions for EventTransform reconciled resources

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Volume mounts use direct

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

* Fix EventTransform with TLS Sink test

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

---------

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: David Simansky <dsimansk@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Marek Schmidt <maschmid@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants