[release-1.17] Add sinks.knative.dev to namespaced ClusterRole
#8433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are roles that users can use to give their developers access to Knative Eventing resources and we're missing the sinks group. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.17 #8433 +/- ##
=============================================
Coverage 64.10% 64.10%
=============================================
Files 388 388
Lines 23363 23363
=============================================
Hits 14976 14976
Misses 7591 7591
Partials 796 796 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/test reconciler-tests |
2 similar comments
Member
|
/test reconciler-tests |
Member
|
/test reconciler-tests |
pierDipi
added a commit
to pierDipi/eventing
that referenced
this pull request
Feb 4, 2025
…tive#8433) Add `sinks.knative.dev` to namespaced ClusterRole These are roles that users can use to give their developers access to Knative Eventing resources and we're missing the sinks group. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
added a commit
to openshift-knative/eventing
that referenced
this pull request
Feb 4, 2025
…ative#8433) (#1049) * [release-1.17] Add `sinks.knative.dev` to namespaced ClusterRole (knative#8433) Add `sinks.knative.dev` to namespaced ClusterRole These are roles that users can use to give their developers access to Knative Eventing resources and we're missing the sinks group. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Run make generate-release Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8432