Skip to content

Update version.go for release 0.23 #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow-robot merged 1 commit into from
May 17, 2021
Merged

Update version.go for release 0.23 #1319

knative-prow-robot merged 1 commit into from
May 17, 2021

Conversation

@rhuss
Copy link
Contributor

@rhuss rhuss commented May 17, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label May 17, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021 •
edited
Loading

Codecov Report

Merging #1319 (91f9f45) into main (bcadd50) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   73.04%   73.04%           
=======================================
  Files         160      160           
  Lines        8161     8161           
=======================================
  Hits         5961     5961           
  Misses       1473     1473           
  Partials      727      727
Impacted Files Coverage Δ
pkg/kn/commands/version/version.go 90.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcadd50...91f9f45. Read the comment docs.

dsimansk
dsimansk approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2021
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented May 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2021
@knative-prow-robot knative-prow-robot merged commit 2f88087 into main May 17, 2021
@dprotaso dprotaso deleted the rhuss-patch-2 branch June 29, 2021 20:02
matejvasek added a commit to matejvasek/client that referenced this pull request Aug 20, 2025
@matejvasek
Update knative.dev/func dep
38c098b 
* Fix non-containerized build/run /w external deps (knative#1317)
* Fix detection of hostname resolution failure (knative#1318)
* Improve Go templates README (knative#1319)
* Tekton 1.0.x fixes (knative#1349)

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek matejvasek mentioned this pull request Aug 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk dsimansk approved these changes

Assignees

@dsimansk dsimansk

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhuss @knative-prow-robot @dsimansk