Fix github action arm image built#948
Conversation
…t is x86-64 arch Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
…t is x86-64 arch Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -0,0 +1,26 @@ | |||
| FROM ghcr.io/kmesh-net/kmesh-build:latest AS builder | |||
There was a problem hiding this comment.
Why need a new dockerfile?Why not modify the original dockerfile?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I will merge this manually, since this is influcencing arm deploy |
|
/cherry-pick release-0.5 |
|
@hzxuzhonghu: new pull request created: #953 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-0.5 |
|
@hzxuzhonghu: new pull request could not be created: failed to create pull request against kmesh-net/kmesh#release-0.5 from head kmesh-bot:cherry-pick-948-to-release-0.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for kmesh-bot:cherry-pick-948-to-release-0.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label cherrypick/release-0.5 |
|
@hzxuzhonghu: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
What this PR does / why we need it:
: without this, though the docker image is ar,64 arch but the kmesh-daemon within it is just x86-64.
Which issue(s) this PR fixes:
Fixes #944
Special notes for your reviewer:
Does this PR introduce a user-facing change?: