Skip to content

modify dockerfile#742

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
weli-l:dev/kmesh_manage
Aug 16, 2024
Merged

modify dockerfile#742
kmesh-bot merged 2 commits intokmesh-net:mainfrom
weli-l:dev/kmesh_manage

Conversation

@weli-l
Copy link
Copy Markdown
Contributor

@weli-l weli-l commented Aug 16, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@weli-l
modify dockerfile
f6c9b8e 
signed-off-by: weli-l <1289113577@qq.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.30%. Comparing base (c544239) to head (f10e507).
Report is 12 commits behind head on main.

see 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24209e8...f10e507. Read the comment docs.

hzxuzhonghu
hzxuzhonghu reviewed Aug 16, 2024
View reviewed changes
Makefile Outdated

.PHONY: docker
docker:
docker:build
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add white space

@weli-l
add white space
f10e507 
signed-off-by: weli-l <1289113577@qq.com>
@hzxuzhonghu
Copy link
Copy Markdown
Member

hzxuzhonghu commented Aug 16, 2024

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label Aug 16, 2024
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit c45453b into kmesh-net:main Aug 16, 2024
@hzxuzhonghu hzxuzhonghu mentioned this pull request Aug 19, 2024
Closed
@hzxuzhonghu hzxuzhonghu mentioned this pull request Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@bitcoffeeiux bitcoffeeiux Awaiting requested review from bitcoffeeiux

@nlgwcy nlgwcy Awaiting requested review from nlgwcy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@weli-l @hzxuzhonghu @kmesh-bot