update Kmesh supported istiod version#1519
Conversation
|
@LiZhenCheng9527: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary of ChangesHello @LiZhenCheng9527, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Kmesh support documentation to accurately reflect the expanded compatibility with additional Istio versions for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Versions now expand, Docs reflect the new support, Path is clear ahead. Footnotes
|
Signed-off-by: LiZhenCheng9527 <lizhencheng6@huawei.com>
fb6253a to
d579206
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the Kmesh support matrix documentation. I've identified a couple of potential inconsistencies introduced by the changes. Firstly, the main/latest version's supported Istio versions appear to lag behind the new 1.1.x release, which is unusual for a main branch. Secondly, the support matrix for 'Kmesh Kernel-Native Mode' has not been updated with the new 1.0.x and 1.1.x versions, which may be an omission. Both issues could mislead users and developers, so I've flagged them as high severity to ensure documentation accuracy.
| | :-------------: | :-------------: | :-------------: | :-------------: | | ||
| | main/latest | >=5.10 | 1.22, 1.23, 1.24 | 1.26, 1.27, 1.28, 1.29, 1.30, 1.31 | | ||
| | main/latest | >=5.10 | 1.23, 1.24, 1.25 | 1.26, 1.27, 1.28, 1.29, 1.30, 1.31 | | ||
| | 1.1.x | >=5.10 | 1.23, 1.24, 1.25 | 1.26, 1.27, 1.28, 1.29, 1.30, 1.31 | |
There was a problem hiding this comment.
With the addition of version 1.1.x, there appears to be an inconsistency with the main/latest entry on the preceding line. This new version supports Istio 1.25, but main/latest is not listed as supporting it. Typically, the main branch supports at least the same versions as the latest release branch, if not more. To avoid confusion for developers, please consider updating the main/latest entry to also include support for Istio 1.25.
| | 1.1.x | >=5.10 | 1.23, 1.24, 1.25 | 1.26, 1.27, 1.28, 1.29, 1.30, 1.31 | | ||
| | 1.0.x | >=5.10 | 1.22, 1.23, 1.24 | 1.26, 1.27, 1.28, 1.29, 1.30, 1.31 | |
There was a problem hiding this comment.
These new versions (1.0.x and 1.1.x) have been added to the 'Kmesh Dual-Engine Mode' support table, but the 'Kmesh Kernel-Native Mode' table further down in the document (lines 24-29) has not been updated. If these versions also support Kernel-Native Mode, that table should be updated as well to ensure the documentation is complete and not misleading for users.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: