Skip to content

[release-1.1] fix flaky of TestCrossNamespace#1414

Merged
kmesh-bot merged 1 commit intokmesh-net:release-1.1from
kmesh-bot:cherry-pick-1413-to-release-1.1
May 19, 2025
Merged

[release-1.1] fix flaky of TestCrossNamespace#1414
kmesh-bot merged 1 commit intokmesh-net:release-1.1from
kmesh-bot:cherry-pick-1413-to-release-1.1

Conversation

@kmesh-bot
Copy link
Copy Markdown
Collaborator

@kmesh-bot kmesh-bot commented May 19, 2025

This is an automated cherry-pick of #1413

@YaoZengzeng
fix flaky of TestCrossNamespace
0a6a801 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot mentioned this pull request May 19, 2025
Merged
hzxuzhonghu
hzxuzhonghu approved these changes May 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label May 19, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator Author

kmesh-bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.33%. Comparing base (6e7064a) to head (0a6a801).
Report is 3 commits behind head on release-1.1.

Files with missing lines Patch % Lines
pkg/controller/manage/manage_controller.go 60.00% 3 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/controller/manage/manage_controller.go 52.87% <60.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a24a49...0a6a801. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmesh-bot kmesh-bot merged commit 4ce6a2c into kmesh-net:release-1.1 May 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kmesh-bot @hzxuzhonghu @YaoZengzeng