Skip to content

fix flaky of TestCrossNamespace#1413

Merged
kmesh-bot merged 1 commit intokmesh-net:mainfrom
YaoZengzeng:fix-crosss
May 19, 2025
Merged

fix flaky of TestCrossNamespace#1413
kmesh-bot merged 1 commit intokmesh-net:mainfrom
YaoZengzeng:fix-crosss

Conversation

@YaoZengzeng
Copy link
Copy Markdown
Member

@YaoZengzeng YaoZengzeng commented May 19, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1357

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@YaoZengzeng
fix flaky of TestCrossNamespace
b7848f1 
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@kmesh-bot kmesh-bot added the kind/bug Something isn't working label May 19, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.24%. Comparing base (8e554d1) to head (b7848f1).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/manage/manage_controller.go 60.00% 3 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
pkg/controller/manage/manage_controller.go 52.87% <60.00%> (+0.06%) ⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e56e0ac...b7848f1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hzxuzhonghu
hzxuzhonghu approved these changes May 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kmesh-bot kmesh-bot added the lgtm label May 19, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented May 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 919600c into kmesh-net:main May 19, 2025
11 checks passed
@kmesh-bot
Copy link
Copy Markdown
Collaborator

kmesh-bot commented May 19, 2025

In response to a cherrypick label: new pull request created: #1414

@kmesh-bot kmesh-bot mentioned this pull request May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@kwb0523 kwb0523 Awaiting requested review from kwb0523

@supercharge-xsy supercharge-xsy Awaiting requested review from supercharge-xsy

Assignees

@hzxuzhonghu hzxuzhonghu

Labels

approved cherrypick/release-1.1 kind/bug Something isn't working lgtm size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TestCrossNamespace failure

3 participants

@YaoZengzeng @kmesh-bot @hzxuzhonghu