Skip to content

[release-1.1] Fix regression by socket tuple when c/s deployed in same node#1387

Merged
kmesh-bot merged 5 commits intokmesh-net:release-1.1from
kmesh-bot:cherry-pick-1378-to-release-1.1
May 9, 2025
Merged

[release-1.1] Fix regression by socket tuple when c/s deployed in same node#1387
kmesh-bot merged 5 commits intokmesh-net:release-1.1from
kmesh-bot:cherry-pick-1378-to-release-1.1

Conversation

@kmesh-bot
Copy link
Copy Markdown
Collaborator

@kmesh-bot kmesh-bot commented May 9, 2025

This is an automated cherry-pick of #1378

hzxuzhonghu added 5 commits May 9, 2025 09:22
@hzxuzhonghu
Fix regression by socket tuple when c/s deployed in same node
8fbb12a 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
Fix ut
84e6821 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
rename confusing names
72d2a32 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
Fix build
3c4ee73 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@hzxuzhonghu
Prevent hardcoding
fbb4c7a 
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@kmesh-bot kmesh-bot mentioned this pull request May 9, 2025
Merged
@kmesh-bot kmesh-bot requested review from hzxuzhonghu and kwb0523 May 9, 2025 09:23
@LiZhenCheng9527
Copy link
Copy Markdown
Contributor

LiZhenCheng9527 commented May 9, 2025

/lgtm
/approve

@kmesh-bot kmesh-bot added the lgtm label May 9, 2025
@kmesh-bot
Copy link
Copy Markdown
Collaborator Author

kmesh-bot commented May 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiZhenCheng9527

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.12500% with 75 lines in your changes missing coverage. Please review.

Project coverage is 46.31%. Comparing base (4b86298) to head (fbb4c7a).
Report is 7 commits behind head on release-1.1.

Files with missing lines Patch % Lines
pkg/controller/telemetry/metric.go 52.94% 68 Missing and 4 partials ⚠️
pkg/controller/telemetry/accesslog.go 57.14% 3 Missing ⚠️
Files with missing lines Coverage Δ
pkg/controller/telemetry/accesslog.go 84.84% <57.14%> (ø)
pkg/controller/telemetry/metric.go 59.61% <52.94%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65667b8...fbb4c7a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kmesh-bot kmesh-bot merged commit fc3ae1b into kmesh-net:release-1.1 May 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@kwb0523 kwb0523 Awaiting requested review from kwb0523

Assignees

@LiZhenCheng9527 LiZhenCheng9527

Labels

approved lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kmesh-bot @LiZhenCheng9527 @hzxuzhonghu