Fix regression by socket tuple when c/s deployed in same node#1378
Fix regression by socket tuple when c/s deployed in same node#1378kmesh-bot merged 5 commits intokmesh-net:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in socket tuple handling when client and server are deployed on the same node. Key changes include:
- Adding a new "direction" field to the connection source/destination structure.
- Renaming variables (e.g. from "connectData" to "rawStats") for clarity.
- Removing the monitoring enabled check in the Run loop.
|
Fix #1370 |
|
unit tests are also be updated |
|
Sure, will do fix it |
|
@yp969803 can you help add ut coverage for same src/dst but different direction case after this pr |
Codecov ReportAttention: Patch coverage is
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
|
/lgtm |
| data.conSrcDstInfo.srcPort = connectData.SrcPort | ||
| reqMetric.conSrcDstInfo.src = rawStats.SrcAddr | ||
| reqMetric.conSrcDstInfo.dst = rawStats.DstAddr | ||
| reqMetric.conSrcDstInfo.direction = rawStats.Direction |
There was a problem hiding this comment.
Is this the root cause of the problem? Too many renames swamping critical changes.
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiZhenCheng9527 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created: #1387 |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1370
Special notes for your reviewer:
Does this PR introduce a user-facing change?: