Conversation
Conni2461
reviewed
Jan 1, 2021
Conni2461
reviewed
Jan 1, 2021
Conni2461
reviewed
Jan 1, 2021
Conni2461
reviewed
Jan 1, 2021
lua/sql/stmt.lua
Outdated
Comment on lines
+97
to
+84
| function M:iter(self) | ||
| return self:next(), self.pstmt | ||
| end |
Collaborator
There was a problem hiding this comment.
If we have a iter we need to make sure it works in a for loop. Right?
Owner
Author
There was a problem hiding this comment.
I think M:loop would be enough. or should we have iter and next?
Collaborator
There was a problem hiding this comment.
I don't know would be cool if you can do for statement:iter() do but i don't think we can write custom iterators in lua. So lets skip on that i think
kkharji
commented
Jan 1, 2021
Conni2461
reviewed
Jan 1, 2021
9d869a4 to
a64d939
Compare
kkharji
commented
Jan 1, 2021
a64d939 to
ab101ec
Compare
kkharji
commented
Jan 1, 2021
kkharji
commented
Jan 1, 2021
Conni2461
reviewed
Jan 3, 2021
Conni2461
reviewed
Jan 3, 2021
Conni2461
reviewed
Jan 3, 2021
Conni2461
reviewed
Jan 3, 2021
Conni2461
reviewed
Jan 3, 2021
f4eda5c to
bb35c7b
Compare
Conni2461
reviewed
Jan 3, 2021
Conni2461
reviewed
Jan 3, 2021
Conni2461
reviewed
Jan 3, 2021
Conni2461
reviewed
Jan 3, 2021
Conni2461
reviewed
Jan 3, 2021
6b68b0e to
9ba6d93
Compare
kkharji
commented
Jan 4, 2021
kkharji
commented
Jan 4, 2021
9ba6d93 to
a8321e6
Compare
Conni2461
reviewed
Jan 4, 2021
b58b452 to
74fdfa3
Compare
kkharji
commented
Jan 4, 2021
kkharji
commented
Jan 4, 2021
kkharji
commented
Jan 4, 2021
74fdfa3 to
6dab7d4
Compare
Closed
It goes well with keys/key types/type val/vals
- combine bind_index and bind_names into bind() - remove index from bind_blob and bind_zeroblob - remove value from bind_next
kkharji
pushed a commit
that referenced
this pull request
Jan 5, 2021
* master: add methods, tests and inline docs for sql statements (#6)
kkharji
pushed a commit
that referenced
this pull request
Jan 5, 2021
* master: add methods, tests and inline docs for sql statements (#6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the following building blocks function to construct more complex use cases:
Main
stmt:parse()stmt:parse()stmt:parse()stmt:parse()stmt:parse()Helpers
stmt:step()stmt:reset():stmt:finalize():BIND
stmt:bind(n, value):stmt:bind_names(nametable):stmt:param_size():stmt:param_name(n):stmt:clear_bindings():stmt:bind_values():GET
stmt:nkeys()stmt:nrows()stmt:types()stmt:type()stmt:keys()stmt:key()stmt:kt()stmt:kv()stmt:val()stmt:vals()stmt:kvrows()stmt:vrows()Misc
stmt:last_insert_rowid():