Conversation
ShanaryS
left a comment
There was a problem hiding this comment.
Looks good, the only reason I kept the Anki button at the top is to make it clear it applies to all tracks at once but it shouldn't be pressed often anyways.
I didn't see any changes to have the lemmas from the json calculated if missing, is that for a later PR?
Oh.. forgot about that. I'll move the buttons back up. Should be easy enough for the user should figure out that they need to enable stuff for the buttons to work.
I also didn't know that we wanted to do this.. if importing JSON, then most likely the words were exported with lemmas in the first place, is this something we expect to happen often? |
I was referring to this comment: #853 (comment) By combing the clipboard and file import we can now parse any missing lemmas since the user can chose the track to parse with. |
- Moved word DB buttons back to top - Removed track selector from import dialog because local tokens are trackless - Maturity + state inputs are displayed lazily, after previewing, since those options are not applied to 'import from file'
Deploying asbplayer with
|
| Latest commit: |
8787f01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73e213ab.asbplayer.pages.dev |
| Branch Preview URL: | https://annotation-settings-rearrang.asbplayer.pages.dev |
|
@ShanaryS I've added the lemmatization but it will be done regardless of whether the record already has lemmas or not - I opted against adding an option for now since I thought it might be confusing given that the dialog already has a Yomitan API URL input, implying that parsing will be done. Maybe we could add a checkbox to the effect of 'lemmatize only if record has no lemmas,' but this starts getting confusing since the behavior would only be affected in the case of "import from file" and not "import from clipboard." I guess this is the tradeoff with using the same dialog for two slightly different behaviors. |
|
I also updated the dialog UI slightly: 
|
- split clipboard string before tokenize bulk - use Partial<DictionaryTokenRecord> - lemmatize imported file records only if lemmas are missing
* Rearrange annotation settings * Address feedback + additional changes to import dialog - Moved word DB buttons back to top - Removed track selector from import dialog because local tokens are trackless - Maturity + state inputs are displayed lazily, after previewing, since those options are not applied to 'import from file' * Restore track selector as 'yomitan api URL' selector in import dialog * Only lemmatize if imported record does not already have lemmas * Address feedback - split clipboard string before tokenize bulk - use Partial<DictionaryTokenRecord> - lemmatize imported file records only if lemmas are missing * Fix keyboard shortcut tab not scrolling when navigated to from dictionary settings
* Rearrange annotation settings * Address feedback + additional changes to import dialog - Moved word DB buttons back to top - Removed track selector from import dialog because local tokens are trackless - Maturity + state inputs are displayed lazily, after previewing, since those options are not applied to 'import from file' * Restore track selector as 'yomitan api URL' selector in import dialog * Only lemmatize if imported record does not already have lemmas * Address feedback - split clipboard string before tokenize bulk - use Partial<DictionaryTokenRecord> - lemmatize imported file records only if lemmas are missing * Fix keyboard shortcut tab not scrolling when navigated to from dictionary settings
Rearranged annotation settings mostly as discussed:
Screen.Recording.2026-01-22.at.8.58.17.AM.mov