enhancement(yomitan): support optimizations for tokenization#838
Merged
killergerbah merged 1 commit intokillergerbah:mainfrom Dec 15, 2025
Merged
enhancement(yomitan): support optimizations for tokenization#838killergerbah merged 1 commit intokillergerbah:mainfrom
killergerbah merged 1 commit intokillergerbah:mainfrom
Conversation
Owner
|
I don't have any comments to add, just want to test with your suped-up Yomitan when I get a chance this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature is guarded by a version check so it won't try to use it, it's currently always set to
falseuntil the Yomitan PR yomidevs/yomitan#2251 is resolved. In the event there are any changes there, the implementation can be easily tweaked before enabling the version check.I'm making a PR now as the
IndexedDBcode was written on top of it. I refactored the Yomitan class to be per track rather than global as there is too much state to manage now per track. Also fixes #837.