Export extra tables #2098
Merged
Export extra tables #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierre
reviewed
Feb 26, 2025
| .bind("accountRecordId", context.getAccountRecordId()) | ||
| .bind("tenantRecordId", context.getTenantRecordId()) | ||
| .bind("accountRecordId", finalTableType == TableType.EXTRA ? accountId : context.getAccountRecordId()) | ||
| .bind("tenantRecordId", finalTableType == TableType.EXTRA ? tenantId : context.getTenantRecordId()) |
Member
There was a problem hiding this comment.
This doesn't sound right: tenantId vs tenantRecordId?
Contributor
Author
There was a problem hiding this comment.
tenantRecordId is just the name of the parameter, the actual column name is tenant_id in case of the aviate_catalog_xxx tables. See this line. See also this comment and this slack thread.
util/src/main/java/org/killbill/billing/util/config/definition/ExportConfig.java
Outdated
Show resolved
Hide resolved
nick-at-finix
pushed a commit
to nick-at-finix/killbill
that referenced
this pull request
May 5, 2025
* Changes for aviate-354 * Move testExportDataWithAviateTables to separate class to debug ci failure * Debug ci failure * Debug ci failure * enable test * Changes to include tenant level plans * Add missing table creation statements * Remove aviate-specific info and use extra.tables.prefix * Remove empty DB check to avoid H2 failure * Remove empty DB check to avoid H2 failure * Drop custom tables at the beginning of each test and add back empty database check. * Code cleanup * Debug ci failure * Debug ci failure * Debug ci failure * Changes as per review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature to export extra tables to address https://github.com/killbill/killbill-aviate-plugin/issues/354. The
org.killbill.export.extra.tables.prefixproperty needs to be set to the prefix of the tables that need to be exported. For the sake of simplicity, we are assuming that the extra table have theaccount_idandtenant_idcolumns.With regards to the ci failure, there is some leftover data in case of H2. So I've disabled some assertions for now.
Finally, there are a lot of intermediate commits for the purpose of debugging the ci failure. So I would suggest we squash and merge this PR.