This repository was archived by the owner on Jan 29, 2023. It is now read-only.
change variable period from unsigned long to float#7
Merged
khoih-prog merged 1 commit intokhoih-prog:mainfrom Oct 8, 2021
Merged
change variable period from unsigned long to float#7khoih-prog merged 1 commit intokhoih-prog:mainfrom
khoih-prog merged 1 commit intokhoih-prog:mainfrom
Conversation
Owner
|
Thanks for the PR which is looking perfect to me. I'm merging it now and will publish a new release, certainly with a note about your contrbution. It seems that this drawback can happen to many other TimerInterrupt-related libraries of mine. I'll spend some time to go thru all of them and fix / improve. Looking forward to receiving more contributions from you. Best Regards, |
khoih-prog
added a commit
that referenced
this pull request
Oct 8, 2021
### Releases v1.5.0 1. Improve frequency precision by using float instead of ulong, Check PR [change variable period from unsigned long to float #7](#7) 2. Remove compiler warnings 3. Update `Packages' Patches` 4. Add `strict` option for PIO `lib_compat_mode` 5. Split `changelog.log` from `README.md`
khoih-prog
added a commit
that referenced
this pull request
Oct 8, 2021
### Releases v1.5.0 1. Improve frequency precision by using float instead of ulong, Check PR [change variable period from unsigned long to float #7](#7) 2. Remove compiler warnings 3. Update `Packages' Patches` 4. Add `strict` option for PIO `lib_compat_mode` 5. Split `changelog.log` from `README.md`
khoih-prog
added a commit
that referenced
this pull request
Oct 8, 2021
### Releases v1.5.0 1. Improve frequency precision by using float instead of ulong, Check PR [change variable period from unsigned long to float #7](#7) 2. Remove compiler warnings 3. Update `Packages' Patches` 4. Add `strict` option for PIO `lib_compat_mode` 5. Split `changelog.log` from `README.md`
Owner
|
The new SAMD_TimerInterrupt releases v1.5.0 has just been published. Your contribution is noted in Contributions and Thanks Best Regards, Releases v1.5.0
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my application I need interrupt frequencies of 12000 Hz and 12050 Hz. With the current library this was not possible because both values led to the same interrupt frequency.
My solution is to change the variable period from unsigned long to float. This gives more resolution at high interrupt frequencies.
Unfortunately I don't know if this affects other functions...
Could you please have a look on this.