feat(web): better locked-flick resetting behaviors 🐵#9991
Closed
jahorton wants to merge 2 commits intochange/web/polish-passfrom
Closed
feat(web): better locked-flick resetting behaviors 🐵#9991jahorton wants to merge 2 commits intochange/web/polish-passfrom
jahorton wants to merge 2 commits intochange/web/polish-passfrom
Conversation
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined |
Contributor
Author
|
Closing this PR; its changeset has been rebased and merged into #9957. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I won't claim this gets everything 100% perfect, but there have been a few oddities with "locked flick" direction resetting that I noticed, even after previous work. So, I put in the effort to have the actual gesture-engine state machine have far more knowledge about what flick types are supported, etc, in order to have more consistency in the handling and make the interactions generally cleaner.