Conversation
Fixes #9869. Adds a 'Description' field, tweaks Copyright strings, and tweaks default content for documentation to the New Project wizards and kmconvert.
User Test ResultsTest specification and instructions
|
69 tasks
69 tasks
8 tasks
darcywong00
reviewed
Nov 7, 2023
| TKeyboardUtils.IsValidKeyboardID(Trim(editKeyboardID.Text), True) and | ||
| (GetTargets <> []); | ||
| (GetTargets <> []) and | ||
| (Trim(memoDescription.Text) <> ''); |
Contributor
There was a problem hiding this comment.
I was thinking
Suggested change
| (Trim(memoDescription.Text) <> ''); | |
| (GetDescription <> ''); |
would be more DRY. But then it would involve changing the other ones, and then
I saw GetKeyboardID returns a Trim(LowerCase(editKeyboardID.Text)), so maybe nvm
69 tasks
Test Results
..New Description field
..README.md 
..readme.htm 
..welcome.htm 
..Description in Package view 
|
Test Results
..New Description field 
..READMEN.md 
..readme.htm 
..welcome.htm 
..Description in Package view 
|
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.211-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9869.
Adds a 'Description' field, tweaks Copyright strings, and tweaks default content for documentation to the New Project wizards and kmconvert.
User Testing
TEST_NEW_KEYBOARD_PROJECT: Create a new keyboard project, and verify that the Description field is visible in the resulting README.md, readme.htm, welcome.htm, and in the Description field of the package. Check also that the Copyright string starts with the word 'Copyright'.
TEST_NEW_MODEL_PROJECT: Create a new lexical model project, and verify that the Description field is visible in the resulting README.md, readme.htm, welcome.htm, and in the Description field of the package. Check also that the Copyright string starts with the word 'Copyright'.