feat(developer): Support v2.0 projects in TIKE 🦕#9949
Merged
Conversation
Relates to #9948. Starts basic support for v2.0 projects. For all operating modes: - Remove blank projects / untitled projects mode - Add Open Project Folder buttons and links - Remove Project Save As - Render uses in-memory XML - Upgrade to v2.0 project file (along with checks) For v2.0 projects: - Remove 'Add File to Project' - Populate Files to list all files in folder (note: consider efficiency here as currently files are parsed for subfile data) - Version 2.0 project options and defaults
User Test ResultsTest specification and instructions
Test Artifacts |
69 tasks
Test Results
..warning message 1 
|
Member
Author
Yes, that is an expected message, looks good thank you. (A future PR will also make those messages clearer) |
..Tamil keyboard in Windows 
..Tamil keybaord in iPhone 
|
Test Results
|
darcywong00
reviewed
Nov 13, 2023
| if DirectoryExists(FFileName) then | ||
| begin | ||
| // This is an attempt to open a project folder? | ||
| // TODO |
Contributor
There was a problem hiding this comment.
Does this get a warning message?
Member
Author
There was a problem hiding this comment.
No, it's a TODO to finish the functionality; captured in #9948.
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.211-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #9948. See that issue for remaining work items.
This PR starts basic support for v2.0 projects.
For all operating modes:
For v2.0 projects:
here as currently files are parsed for subfile data)
User Testing
TEST_OPEN_PROJECT: Verify that opening an existing project continues to function correctly. Try basic project functions, such as opening files in the project, building keyboards (from the buttons in the Project view), adding files.
TEST_NEW_PROJECT: Verify that creating a new basic keyboard project continues to function correctly.
TEST_UPGRADE_PROJECT: When opening an existing project, an Upgrade banner should appear. Click the button to upgrade the project, and follow the prompts. Load the result .kpj file in a text editor and verify (a) that the
<Version>field now reads '2.0', and (b) that there are no<File>entries in the .kpj file.