Skip to content

chore(windows): remove keyman_forcekeyboard#8745

Merged
rc-swag merged 5 commits intochore/windows/5442/remove-legacy-keyman-corefrom
chore/windows/8646/remove-force-keyboard
May 16, 2023
Merged

chore(windows): remove keyman_forcekeyboard#8745
rc-swag merged 5 commits intochore/windows/5442/remove-legacy-keyman-corefrom
chore/windows/8646/remove-force-keyboard

Conversation

@rc-swag
Copy link
Copy Markdown
Contributor

@rc-swag rc-swag commented May 10, 2023 •
edited
Loading

Fixes: #8646

User Testing

TEST_SELECT_DIFFERENT_KBDS

Install two or three keyboards such as Tamil 99 keyboard and Khmer Angkor keyboard

  • Open Notepad, select the Tamil Keyboard
  • Type in some characters and ensure they are output
  • Select the Khmer_Angkor Keyboard
  • Type in some characters and ensure they are output
  • Verify that typing produces the expected output
  • Select Tamil Keyboard again
  • Verify that typing produces the expected output

@rc-swag rc-swag added this to the A17S12 milestone May 10, 2023
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label May 10, 2023
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented May 10, 2023 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_SELECT_DIFFERENT_KBDS (PASSED): Tested with the attached PR build (17.0.87-alpha-test-8745) in Windows 11 OS (VM) and here is my observation: 1. Installed Tamil, Khmer and IPA (SIL) keyboards using Keyman Configuration dialog. 2. Opened Notepad app. 3. Able to switch between these three keyboards and the relevant fonts appears on the notepad correctly. Seems to be working fine. (notes)

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels May 10, 2023
rc-swag
rc-swag commented May 11, 2023
View reviewed changes
@rc-swag rc-swag marked this pull request as ready for review May 12, 2023 08:23
@mcdurdin mcdurdin modified the milestones: A17S12, A17S13 May 14, 2023
mcdurdin
mcdurdin approved these changes May 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented May 15, 2023

Test Results

  • TEST_SELECT_DIFFERENT_KBDS (PASSED): Tested with the attached PR build (17.0.87-alpha-test-8745) in Windows 11 OS (VM) and here is my observation: 1. Installed Tamil, Khmer and IPA (SIL) keyboards using Keyman Configuration dialog. 2. Opened Notepad app. 3. Able to switch between these three keyboards and the relevant fonts appears on the notepad correctly. Seems to be working fine.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label May 15, 2023
@rc-swag rc-swag force-pushed the chore/windows/8646/remove-force-keyboard branch from fbcba90 to 65ef3d0 Compare May 16, 2023 03:31
@rc-swag rc-swag merged commit 9790f1c into chore/windows/5442/remove-legacy-keyman-core May 16, 2023
@rc-swag rc-swag deleted the chore/windows/8646/remove-force-keyboard branch May 16, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@ermshiperete ermshiperete Awaiting requested review from ermshiperete

@darcywong00 darcywong00 Awaiting requested review from darcywong00

@jahorton jahorton Awaiting requested review from jahorton

@sgschantz sgschantz Awaiting requested review from sgschantz

@SabineSIL SabineSIL Awaiting requested review from SabineSIL

Assignees

No one assigned

Labels

chore developer/ide/ developer/ has-user-test windows/engine/ windows/

Projects

None yet

Milestone

A17S13

Development

Successfully merging this pull request may close these issues.

3 participants

@rc-swag @bharanidharanj @mcdurdin