chore(window): rename core functions ⛏️#8707
Merged
rc-swag merged 4 commits intochore/windows/8681/remove-addinsfrom May 15, 2023
Merged
chore(window): rename core functions ⛏️#8707rc-swag merged 4 commits intochore/windows/8681/remove-addinsfrom
rc-swag merged 4 commits intochore/windows/8681/remove-addinsfrom
Conversation
User Test ResultsTest specification and instructions
Test Artifacts |
LoadKeyboardOptionsREGCore -> LoadKeyboardOptionsRegistrytoCore SaveKeyboardOptionREGCore -> SaveKeyboardOptionCoretoRegistry
ermshiperete
reviewed
May 4, 2023
Contributor
ermshiperete
left a comment
There was a problem hiding this comment.
I'm wondering about the Load/SaveKeyboardOptions* methods - is the "Core" relevant here, or would they be better called LoadKeyboardOptionsFromRegistry and SaveKeyboardOptionsToRegistry?
| BOOL IntLoadKeyboardOptionsCore(LPCSTR key, LPINTKEYBOARDINFO kp, km_kbp_state* const state); | ||
| void IntSaveKeyboardOptionREGCore(LPCSTR REGKey, LPINTKEYBOARDINFO kp, LPCWSTR key, LPWSTR value); | ||
| BOOL IntLoadKeyboardOptionsRegistrytoCore(LPCSTR key, LPINTKEYBOARDINFO kp, km_kbp_state* const state); | ||
| void IntSaveKeyboardOptionCoretoRegistry(LPCSTR REGKey, LPINTKEYBOARDINFO kp, LPCWSTR key, LPWSTR value); |
Contributor
There was a problem hiding this comment.
Do you want to add an s to make the names between loading and saving consistent? (Similar in the other method names)
Suggested change
| void IntSaveKeyboardOptionCoretoRegistry(LPCSTR REGKey, LPINTKEYBOARDINFO kp, LPCWSTR key, LPWSTR value); | |
| void IntSaveKeyboardOptionsCoretoRegistry(LPCSTR REGKey, LPINTKEYBOARDINFO kp, LPCWSTR key, LPWSTR value); |
Contributor
Author
There was a problem hiding this comment.
Loading and Saving are not exactly symmetrical. The Loading works on a list of options whereas saving saves only a single option, it is a deliberate option to leave the s off.
|
Test Results
|
mcdurdin
approved these changes
May 5, 2023
ermshiperete
requested changes
May 5, 2023
Contributor
ermshiperete
left a comment
There was a problem hiding this comment.
LGTM but flagging as "Request changes" so that my questions don't slip off the radar with multiple comments after them...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8703
This follows on the removal of addins.
I made the decision to remove
These functions are about saving and restoring the keyboard option list in the core used in the case of testing a keystroke in the NonUpdateable case. Due to the optimisation of just using the cached core actions in the case of the !Updateable call there is no longer a need for these 3 functions and their test cases so can be removed as dead code.
UpdateKeyboardOptionsCore
SaveKeyboardOptionsCore
RestoreKeyboardOptionsCore
DisposeKeyboardOptionsCore
Removed the core name
MapKeyboardCore
MapKeyRuleCore
LoadKeyboardOptionsREGCore -> LoadKeyboardOptionsRegistrytoCore
SaveKeyboardOptionREGCore -> SaveKeyboardOptionCoretoRegistry
User Testing
TEST_KEYBOARDOPTIONS_CHANGE:
This test requires IPA (SIL) keyboard to be installed (or a keyboard that has modifiable keyboard options).
Step 1. Go to
Keyman Configuration, select the IPA (SIL) keyboard, click onKeyboard optionsand chooseBefore.Step 2. Open Notepad, start typing anything and notepad should NOT crash.
Step 3. Type
>bStep 4. Expected output
ɓStep 5. Exit Notepad and Keyman
Step 6. Go to
Keyman Configuration, select the IPA (SIL) keyboard, click onKeyboard optionsand chooseAfter.Step 7. Type
>bStep 8. Expected output
ɓNote:
BeforeAftersetting. This will change the sequence to produce the IPA character for example>b=>ɓfor before and if the setting is after it isb>=>ɓTEST_PRESERVEDKEYS
This is to test the key rules which contain AltGr or Shift + AltGr work correctly.
Load a keyboard
khmer_angkorOpen LibreOffice or Notepad
Type a AltGr + o
Observere output of ឱ
Type a Shift + AltGr + o
Observere output of ᧨