Skip to content

chore(windows): Rename functions if "Core" in name is redundant ⛏️ #8703

@rc-swag

Description

@rc-swag

The following functions can be renamed or even removed now that legacy core has been removed. #8593

  • // Core was mainly as a point of difference vs the windows engine core while the feature flag was present. So could remove the core name
    ReleaseKeyboardMemoryCore
    ReleaseStateMemoryCore

  • // These functions are about saving and restoring the keyboard option list in the core. used in the case of testing a keystroke
    // Due to the optimisation of just using the cached core actions in the case of the !Updateable call there is no longer a need for these 3
    // functions and there test cases so can be removed as dead code.
    UpdateKeyboardOptionsCore
    SaveKeyboardOptionsCore
    RestoreKeyboardOptionsCore
    DisposeKeyboardOptionsCore

  • // Used for loading and saving options between the core loaded keyboard and the windows registry. Core was mainly as a point of difference vs the windows engine core while the feature flag was present.
    // it does cary more meaning and suggest a name the suggest the flow of data LoadKeyboardOptionsREGtoCore. SaveKeyboardOptionCoretoReg
    LoadKeyboardOptionsREGCore
    SaveKeyboardOptionREGCore

  • // Was named when refactoring the ProcessEvent call to be better optimised around the TSF not updatable call
    Process_Event_Core

  • // The Core was mainly as a point of difference vs the windows engine core while the feature flag was present. So could remove the core name
    MapKeyboardCore
    MapKeyRuleCore

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions