fix(android/app): Resize OSK when resuming app from background#8704
Merged
darcywong00 merged 1 commit intomasterfrom May 5, 2023
Merged
fix(android/app): Resize OSK when resuming app from background#8704darcywong00 merged 1 commit intomasterfrom
darcywong00 merged 1 commit intomasterfrom
Conversation
User Test ResultsTest specification and instructions
Test Artifacts |
Member
|
Should this be cherry-picked to stable? |
Contributor
Author
|
imho - the issue isn't a crash and the OSK refreshes when reorienting the app, so maybe we can skip cherry picking. |
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.101-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8550
When Keyman app is in the foreground and the device is rotated,
onConfigurationChanged()triggers which handles resizing the OSK.If Keyman is in the background while the device is rotated, resuming the app does not trigger
onConfigurationChanged().This only affects the in-app keyboard. Note, on old Android devices (e.g. Android 5.0 / SDK 21), the app is recreated so the OSK always appears fine.
This PR adds a check to
onResume()to handle resizing the OSK if needed.User Testing
Setup - Install the PR build of Keyman for Android on a recent Android device/emulator (Anything newer than Android Oreo will do). Note, some Android devices use an "orientation" button on the navigation bar to trigger orientation changes. Press the button as necessary when rotating between portrait / landscape.