chore(common): add missing deps and files for npm publish#8588
Merged
chore(common): add missing deps and files for npm publish#8588
Conversation
The build/ folder for most packages was missing due to being listed in .gitignore. Also, @keymanapp/ldml-keyboard-constants package was not being published despite being a dependency of @keymanapp/kmc-keyboard. Instead of relying on npm's use of .gitignore / .npmignore (which has seriously wonky behaviours), we list the files that should be included in package.json. NPM Wonky behaviours: it seems that .npmignore causes .gitignore in the same folder to be ignored. But, higher level .gitignore files still affect the files included in the package, which makes specification-by-exclusion painful (negating exclusions, etc). We do not recommend use of .npmignore anywhere for this reason.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
2 tasks
Base automatically changed from
fix/common/7310-npm-publish-needs-to-hardcode-dep-versions
to
master
April 13, 2023 08:08
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.87-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build/ folder for most packages was missing due to being listed in .gitignore.
Also, @keymanapp/ldml-keyboard-constants package was not being published despite being a dependency of @keymanapp/kmc-keyboard.
Instead of relying on npm's use of .gitignore / .npmignore (which has seriously wonky behaviours), we list the files that should be included in package.json.
NPM Wonky behaviours: it seems that .npmignore causes .gitignore in the same folder to be ignored. But, higher level .gitignore files still affect the files included in the package, which makes specification-by-exclusion painful (negating exclusions, etc). We do not recommend use of .npmignore anywhere for this reason.
@keymanapp-test-bot skip